ireade / accessible-modal-dialog Goto Github PK
View Code? Open in Web Editor NEWAn accessible modal dialog
Home Page: https://ireade.github.io/accessible-modal-dialog/
An accessible modal dialog
Home Page: https://ireade.github.io/accessible-modal-dialog/
accessible-modal-dialog/Dialog.js
Line 26 in b5746cb
You've got a memory leak in Dialog.open()
. Every time a dialog is opened, a new keypress event handler is added to the dialog and a new click handler to the overlay. If a dialog is opened 100 times, that is 200 event handlers for the browser to process. For a navigation menu, this is unlikely, but for other modal dialog uses, it could potentially become problematic.
Clicking the "Accessible Dialog" header/link redirects to https://ireade.github.io which is a 404
Page scrolling when a dialog is open is still possible, such as with a trackpad swipe or mouse wheel. Adding overflow:hidden
to the body via a class may solve this.
accessible-modal-dialog/Dialog.js
Line 68 in b5746cb
This breaks when some of the focusable elements are hidden (out of view) such as in a multi-step flow.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.