ipfs / github-mgmt Goto Github PK

I'm trying to merge an approved PR in the specs repo, but do not appear to have permissions to do so: ipfs/specs#312

It is not clear to me what i should be proposing to change with the permissions definition here to fix that:
https://github.com/ipfs/github-mgmt/blob/master/github/ipfs.yml#L4139-L4165

• - Specs Stewards get push access, as do I, which i think is enough to make the PR
• the branch protection is just that it is protected:

branch_protection:
      main: {}

the github docs I can find just say: "By default, each branch protection rule disables force pushes to the matching branches and prevents the matching branches from being deleted." which does imply why an approved PR can't be merged.

I can't see settings on the repo so don't know if settings for what the branch protection is structured as match or are more restrictive than what's listed in this repo.

https://www.npmjs.com/package/renovate claims to be able to handle dependency upgrade management, and has a fairly large following. Could it help us stay out of the situation we're in with ipfs/ipfs-webui#1965?

Context: In awesome-ipfs, I added https://github.com/ipfs/awesome-ipfs/blob/master/dangerfile.js which can help to block and give more information in a comment on PRs. I talked with @lidel about this and we agreed that this would be a good addition to many of our repos.

Danger currently only has official runners for JS, ruby, swift, python, and kotlin, but there is the possibility to create a danger-runner in any language (Go, Rust, etc..): https://danger.systems/js/usage/danger-process.html
The ask for this issue is that we come up with a base file that would work for multiple repos to use as a default. Some default rules we could use are:

1. Warning on large PRs (over X lines changed)
2. Fail when src/ is modified without test/ modified
3. Display lint/test failures
4. Display code coverage changes (This should probably be done via codecov)

And there are other examples and plugins listed at https://danger.systems/js/

A few issues I could see with implementing this in github-mgmt:

1. Accidentally overwriting a customized danger file
2. Setting rules that are too strict for some repos

So I guess the main goal here is to make it easy for ipfs repos to get a danger file that works, and then be allowed to modify it for their needs as appropriate.

Auto-merged commits like this one create releases in repos that release with every change to master (e.g. most JS repos).

Please can they have [skip ci] added to the end of their commit messages so that CI is skipped and releases are not created.

Also, adding chore: to the beginning of the message will ensure an appropriate entry is added to the changelog, where changelogs are generated.

Triage access comes with review requesting powers which would make the process more friendly for org members.

I see

I also couldn't find label support in this repo at all. Is there a list of labels that we add to all repos and how do I propose adding a label to that list?

Action to add to all repos is https://github.com/ipfs/ipfs-desktop/blob/main/.github/workflows/auto-project.yml.

See #4 for example of what it should look like (though in yaml, not json)

Actions required

• chore: Create org-wide token for auto-project.yml workflow
• TBD

I think to begin with it could be as simple as a concrete set of instructions in the ISSUE_TEMPLATE.

Things I was wondering about:

• should we ask submitters to mention their PL managers (if applicable)
• could we extract "owners" out of the modified resources

Might be related: give org members ability to ask for reviews - #33