Code Monkey home page Code Monkey logo

geonames's People

Contributors

alexeyshockov avatar ipalaus avatar javiermartinz avatar jrmadsen67 avatar nitper avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

geonames's Issues

composer package dependency for L4.2

Hi!
It seems to be unable to install the composer package within Laravel 4.2 - it fails on dependency symfony/process 2.4..
But Laravel 4.2 requires at least symfony/process: 2.5.
(since 4.2.0)

Importer timed out on --development seed

I was running the importer with the --development option enabled, and one of the Seeders timed out. Wish I knew which one, because when I manually ran each seeder that would have ran during the ImportCommands process individually, it worked just fine.

Could it be due to my Vagrant box not having the fastest specs? Just thought I'd ping you to see what it could be.

PSR-2 code style

Hello!

What do you think about the code base reformatting using PSR-2 rules?

run() method missing from DatabaseSeeder

Hi,

Looks like Seeders\DatabaseSeeder now has to implement a run() method.
Without that I have the following error when trying to seed:

Class Ipalaus\Geonames\Seeders\DatabaseSeeder contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Database\Seeder::run)

Cheers

Design thoughts on implementing spatial indexes

Using spatial functions would be a pretty huge win for MySQL users in this library.

Of course, there are a number of ways one could go about this, and since it's not my project, I thought I'd start some discussion on the best way to approach it.

When I took a crack at implementing a GeoNames database before finding this project, I simply added an additional POINT column in the main names table, and adding the SPATIAL INDEX. This of course requires the table be MyISAM [and be using MySQL], but I don't think that's a big deal - I doubt anyone will need transactional support on these tables, and I finally figured out how to get the current DB Driver in Laravel :)

In any case, could I follow that same convention to add it to the main table, or would you prefer it be external - either in a separately managed table, or completely out of scope of this module? It'll be trickier to do it this way, but I suppose it could ensure that the main tables were consistent, regardless of driver or settings.

Migration files are broken L5.2

Well there are 2 problems:

1- The file names are like '2013_11_28_170337_create_geonames_names.php' but the class name inside the file is 'CreateGeonamesNamesTable'. Either the file name should be '2013_11_28_170337_create_geonames_names_table.php' or the class name should be 'CreateGeonamesNames'

Otherwise it just gives error:

  [Symfony\Component\Debug\Exception\FatalThrowableError]
  Class 'CreateGeonamesNames' not found

2- The composer dumpautoload is giving errors about duplicate migration files.

Writing lock file
Generating autoload files
Warning: Ambiguous class resolution, "CreateGeonamesNamesTable" was found in both "$baseDir . '/database/migrations/2013_11_28_170337_create_geonames_names.php" and "/laravel_directory/vendor/ipalaus/geonames/src/migrations/2013_11_28_170337_create_geonames_names.php", the first will be used.

I found the same problem mentioned in another issue but removing the classmap from vendor/ipalaus/geonames/composer.json did not help.

Any ideas on when you will fix these and make a release?

Thanks!

I am trying to upgrade laravel 5.7 to 8 and getting this error

i have removed ipalaus/geonames from composer.json and tried to run composer require ipalaus/geonames .

is it not yet supported in laravel 8.73?

Conclusion: don't install ipalaus/geonames v3.0.1
- Conclusion: remove symfony/console v5.3.11
- Installation request for ipalaus/geonames ^3.0 -> satisfiable by ipalaus/geonames[v3.0, v3.0.1].
- Conclusion: don't install symfony/console v5.3.11
- ipalaus/geonames v3.0 requires symfony/process 2.8.|3.0. -> satisfiable by symfony/process[v2.8.0, v2.8.1, v2.8.10, v2.8.11, v2.8.12, v2.8.13, v2.8.14, v2.8.15, v2.8.16, v2.8.17, v2.8.18, v2.8.19, v2.8.2, v2.8.20, v2.8.21, v2.8.22, v2.8.23, v2.8.24, v2.8.25, v2.8.26, v2.8.27, v2.8.28, v2.8.29, v2.8.3, v2.8.30, v2.8.31, v2.8.32, v2.8.33, v2.8.34, v2.8.35, v2.8.36, v2.8.37, v2.8.38, v2.8.39, v2.8.4, v2.8.40, v2.8.41, v2.8.42, v2.8.43, v2.8.44, v2.8.45, v2.8.46, v2.8.47, v2.8.48, v2.8.49, v2.8.5, v2.8.50, v2.8.52, v2.8.6, v2.8.7, v2.8.8, v2.8.9, v3.0.0, v3.0.1, v3.0.2, v3.0.3, v3.0.4, v3.0.5, v3.0.6, v3.0.7, v3.0.8, v3.0.9].
- symfony/process v2.8.0 conflicts with symfony/console[v5.3.11]

Installation failed, LA5.5

$ composer require "ipalaus/geonames"

Using version ^3.0 for ipalaus/geonames
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Conclusion: don't install ipalaus/geonames v3.0.1
- Conclusion: remove symfony/console v3.4.2
- Installation request for ipalaus/geonames ^3.0 -> satisfiable by ipalaus/geonames[v3.0, v3.0.1].
- Conclusion: don't install symfony/console v3.4.2
- ipalaus/geonames v3.0 requires symfony/process 2.8.|3.0. -> satisfiable by symfony/process[v2.8.0, v2.8.1, v2.8.10, v2.8.11, v2.8.12, v2.8.13, v2.8.14, v2.8.15, v2.8.16, v2.8.17, v2.8.18, v2.8.19, v2.8.2, v2.8.20, v2.8.21, v2.8.22, v2.8.23, v2.8.24, v2.8.25, v2.8.26, v2.8.27, v2.8.28, v2.8.29, v2.8.3, v2.8.30, v2.8.31, v2.8.32, v2.8.4, v2.8.5, v2.8.6, v2.8.7, v2.8.8, v2.8.9, v3.0.0, v3.0.1, v3.0.2, v3.0.3, v3.0.4, v3.0.5, v3.0.6, v3.0.7, v3.0.8, v3.0.9].
- symfony/process v2.8.0 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.1 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.10 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.11 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.12 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.13 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.14 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.15 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.16 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.17 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.18 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.19 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.2 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.20 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.21 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.22 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.23 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.24 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.25 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.26 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.27 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.28 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.29 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.3 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.30 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.31 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.32 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.4 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.5 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.6 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.7 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.8 conflicts with symfony/console[v3.4.2].
- symfony/process v2.8.9 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.0 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.1 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.2 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.3 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.4 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.5 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.6 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.7 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.8 conflicts with symfony/console[v3.4.2].
- symfony/process v3.0.9 conflicts with symfony/console[v3.4.2].
- Installation request for symfony/console (locked at v3.4.2) -> satisfiable by symfony/console[v3.4.2].

Installation failed, reverting ./composer.json to its original content.

Seeding is broken L5.2

$ php artisan geonames:import
File exists: countryInfo.txt
File exists: allCountries.zip
File exists: alternateNames.zip
File exists: hierarchy.zip
File exists: admin1CodesASCII.txt
File exists: admin2Codes.txt
File exists: featureCodes_en.txt
File exists: timeZones.txt
It is time to seed the database. This may take 'a while'...


  [RuntimeException]
  PHP Fatal error:  Class Ipalaus\Geonames\Seeders\DatabaseSeeder contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Illuminate\Database\Seeder::run) in /vagrant/jobgo.laravel.portal
  /portal/vendor/ipalaus/geonames/src/Seeders/DatabaseSeeder.php on line 6

Artisan migrate:publish available in 4.1

Hi there! I am very interested in using this extension, thank you for taking the time to put it together!

Just a note that migrate:publish is now an artisan command; this should allow you to leverage that in your geonames:install setup.

artisan geonames:seed is broken L5.2

When I call php artisan geonames:seed, i tsimply runs db:seed and tries to push all the unrelated seed data (from my project) also. I expected this command to just seed the geonames tables.

Force TypeCast on importer.php

I need to force type cast of all insert data to work with PostgreSql. Some values came empty from txt files, then it's ever considered an empty string and not match with an integer column in database...

Commands for fetching incremental updates

GeoNames builds two files each day, modifications-$date.txt and deletes-$date.txt, where $date is the previous day. This allows for incremental updates without having to rebuild the entire table.

Having commands that download/store those text files in the meta/geonames directory, as well as separately applying those stored updates incrementally (and delete when applied, perhaps?) would be wonderful for this purpose.

Additionally, with #3, being able to specify feature types would help ensure that no attempts to update or add unneeded (or non-existent) data are made.

Incompatible with latest Laravel ( 5.4.25 )

$ composer require ipalaus/geonames
Using version ^3.0 for ipalaus/geonames
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

Problem 1
- Conclusion: don't install ipalaus/geonames v3.0.1
- Conclusion: remove symfony/process v3.3.2
- Installation request for ipalaus/geonames ^3.0 -> satisfiable by ipalaus/geonames[v3.0, v3.0.1].
- Conclusion: don't install symfony/process v3.3.2
- ipalaus/geonames v3.0 requires symfony/process 2.8.|3.0. -> satisfiable by symfony/process[v2.8.0, v2.8.1, v2.8.10, v2.8.11, v2.8.12, v2.8.13, v2.8.14, v2.8.15, v2.8.16, v2.8.17, v2.8.18, v2.8.19, v2.8.2, v2.8.20, v2.8.21, v2.8.22, v2.8.3, v2.8.4, v2.8.5, v2.8.6, v2.8.7, v2.8.8, v2.8.9, v3.0.0, v3.0.1, v3.0.2, v3.0.3, v3.0.4, v3.0.5, v3.0.6, v3.0.7, v3.0.8, v3.0.9].
- Can only install one of: symfony/process[v2.8.0, v3.3.2].
- Can only install one of: symfony/process[v2.8.1, v3.3.2].
- Can only install one of: symfony/process[v2.8.10, v3.3.2].
- Can only install one of: symfony/process[v2.8.11, v3.3.2].
- Can only install one of: symfony/process[v2.8.12, v3.3.2].
- Can only install one of: symfony/process[v2.8.13, v3.3.2].
- Can only install one of: symfony/process[v2.8.14, v3.3.2].
- Can only install one of: symfony/process[v2.8.15, v3.3.2].
- Can only install one of: symfony/process[v2.8.16, v3.3.2].
- Can only install one of: symfony/process[v2.8.17, v3.3.2].
- Can only install one of: symfony/process[v2.8.18, v3.3.2].
- Can only install one of: symfony/process[v2.8.19, v3.3.2].
- Can only install one of: symfony/process[v2.8.2, v3.3.2].
- Can only install one of: symfony/process[v2.8.20, v3.3.2].
- Can only install one of: symfony/process[v2.8.21, v3.3.2].
- Can only install one of: symfony/process[v2.8.22, v3.3.2].
- Can only install one of: symfony/process[v2.8.3, v3.3.2].
- Can only install one of: symfony/process[v2.8.4, v3.3.2].
- Can only install one of: symfony/process[v2.8.5, v3.3.2].
- Can only install one of: symfony/process[v2.8.6, v3.3.2].
- Can only install one of: symfony/process[v2.8.7, v3.3.2].
- Can only install one of: symfony/process[v2.8.8, v3.3.2].
- Can only install one of: symfony/process[v2.8.9, v3.3.2].
- Can only install one of: symfony/process[v3.0.0, v3.3.2].
- Can only install one of: symfony/process[v3.0.1, v3.3.2].
- Can only install one of: symfony/process[v3.0.2, v3.3.2].
- Can only install one of: symfony/process[v3.0.3, v3.3.2].
- Can only install one of: symfony/process[v3.0.4, v3.3.2].
- Can only install one of: symfony/process[v3.0.5, v3.3.2].
- Can only install one of: symfony/process[v3.0.6, v3.3.2].
- Can only install one of: symfony/process[v3.0.7, v3.3.2].
- Can only install one of: symfony/process[v3.0.8, v3.3.2].
- Can only install one of: symfony/process[v3.0.9, v3.3.2].
- Installation request for symfony/process (locked at v3.3.2) -> satisfiable by symfony/process[v3.3.2].

Installation failed, reverting ./composer.json to its original content.

error seeding

I've executed php artisan geonames:import --country="ES"
and fails after a while.

here console last output:
....
Seeded: ContinentsTableSeeder
Seeded: CountriesTableSeeder
Seeded: AdminDivionsTableSeeder
Seeded: AdminSubdivionsTableSeeder
[Symfony\Component\Process\Exception\RuntimeException]
The process has been signaled with signal "11".

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.