ipa320 / bride Goto Github PK

setting the the queue size of a subscriber in eclipse to any other value than 1 is not taken into account of c++ code-generation

Since I updated the sourcecode today the BRIDE menu is missing in the menu bar so I'm unable to generate code from my models (screenshot below). I tried it both ways, upgrading a previous version and reinstalling bride from scratch. In both cases I made sure, that the ROS_PACKAGE_PATH was set properly.

When there is a .cproject and .project file in the ROS package you want to import. Ask the user if he wants to import directly or overwrite the project files with a new configuration.

If an State is inserted between inital-state and actual first state, this new state will not be executed at first.

When a new publisher will be created with the same message type of an existing publisher, bride adds the same "#include < **.h >" again.

Automatically generate python actionclient for each actionserver implemented in order to easily test the actionserver.

by default there is no way to see which kind of problems the model has

with more than 10 parameters this feature would be very useful to keep an overview

tried to configure a topic with name "123". This is accepted by the model, source code generation is ok too, but build fails due to "error: expected unqualified-id before numeric constant"

--> please check for valid ROS graph names, see http://wiki.ros.org/Names
--> this probaly has to be done for all ROS names (nodes, topics, services, actions,, parameters)

When transforming a BCM model to a ROS model the transformation exits with a popup saying:

"An internal error occurred during: "BCM to ROS".
java.lang.NullPointerException"

Happening in version: 0.2.0

To see if the build has succeeded or failed, the user has to scroll up in the console.
Would be great if it would be in the last output.

Modify templates to also generate correct source code in python

Again a feature request. How do you properly model a synchronizer for incoming messages? Should it be provided by BRIDE or is it better to create a separate node manually that acts as a synchronizer and forwards the results to other nodes?

most of the bride users have difficulties understanding why service clients and action clients are on the left side of the model (inputs) but service servers and action servers on the right side (outputs). Most of them would swap that around because the servers are triggered from an external component while the clients are actively triggered by the modelled component itself.

options:

• swap servers and clients
• find an alternative representation (maybe on the top and/or bottom of the model)

Would speed up build time during development.

The following tutorial page is no longer coorect:
http://wiki.ros.org/bride/Tutorials/Creating-ros-coordinators-with-bride

In the properties settings, eclipse demnads for a "goal" parameter, which is not described in the tutorial

Same as for mesage filters: ROS provides image_transport as a wrapper for standard publisher subscribers in order to send images over the wire from one node to another. Bride seems not yet to support this.

It still uses make, while installation page suggests catkin_make, which works for me (make didn't`).

explain internal coordination model in a diagramm:
configure - trigger - read inputs - update - send outputs - trigger - ...

should list the following possibilities:

• trigger update by fix loop_rate
• trigger by callbacks
• mixed version

After creating a new coordinator diagram, the name field in the package properties is blank and cannot be changed. When saving the model eclipse complains about the 'missing name of package'

Actually a feature request: At the moment it seems not to be possible to model sub/pubs using message_filters library for synchronization and image reception.

Setup corresponding project settings for code indexing.

Change code generation from
generate_dynamic_reconfigure_options(cfg/node1.cfg)
generate_dynamic_reconfigure_options(cfg/node2.cfg)

to

generate_dynamic_reconfigure_options(cfg/node1.cfg cfg/node2.cfg)

this causes build errors with catkin_make

This prevents the execution of catkin_make in the catkin workspace as it complains about the missing CMake file

required:

• author
• author email
• description
• license (bug: is not checked as required currently)

optional:

• depend
• url

Error message:
CMake Error at /opt/ros/hydro/share/dynamic_reconfigure/cmake/extras.cmake:60 (add_custom_target):
add_custom_target cannot create target "test_aub_gencfg" because another
target with the same name already exists. The existing target is a custom
target created in source directory "/home/fmw/git/care-o-bot/src/test_aub".
See documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
test_aub/CMakeLists.txt:20 (generate_dynamic_reconfigure_options)

CMakeLists.txt looks like:
generate_dynamic_reconfigure_options(cfg/node1.cfg)
generate_dynamic_reconfigure_options(cfg/node2.cfg)

and should probably be:
generate_dynamic_reconfigure_options(cfg/node1.cfg cfg/node2.cfg)

for cpp and for py

While code for action and serviceservices is generated, the templates are missing implementations of clients.
Both for c++ and python templates.

I failed creating a package because I used the default location "~/catkin_ws/src" for creating a new package "my_test_package".
Correct would be to "mkdir /catkin_ws/test" and then run the wizard and select "/catkin_ws/src/my_test_package" as location.

this is not very intuitive for the user, especially not when the default location can never be uses this way.

Suggestions:

• do not let the user create a package through the wizzard if the package name is not the same as the location directory
• elimintate the "use default location" checkbox

or

• create the directory with the package name automatically in the background

Once BRIDE has generated the C++ source code and you change the node name afterwards, BRIDE does not update all necessary files where the node name appears. Instead, one has to manually delete all files and then do a rebuild with bride

e.g. package.xml and CMakelists (file which have no protected regions) but also cpp and py files
let the user decide which parts should be overwritten e.g. by using meld (or similar tool)

This caused me troubles:

• when generating python and cpp code from the same model.
• when adding a second author or maintainer

I'm unable to create a new project in the eclipse workspace directory (exception below). However, any other project paths outside the root workspace directory (including subdirectories) work fine.

[...]
-- Using PYTHON_EXECUTABLE: /usr/bin/python
-- Python version: 2.7
-- Using Debian Python package layout
-- Using CATKIN_ENABLE_TESTING: ON
-- Call enable_testing()
-- Using CATKIN_TEST_RESULTS_DIR: /home/uhr-se/catkin2_ws/random_package_name/bride/test_results
-- Found gtest sources under '/usr/src/gtest': gtests will be built
-- catkin 0.5.86
-- Configuring done
-- Generating done
-- Build files have been written to: /home/uhr-se/catkin2_ws/random_package_name/bride
Finished catkin_create_pkg
org.eclipse.core.internal.resources.ResourceException: Invalid project description.
    at org.eclipse.core.internal.resources.Project.checkDescription(Project.java:175)
    at org.bride.wizards.ROSPackageWizard$2.execute(ROSPackageWizard.java:142)
    at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:106)
    at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
    at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:118)
    at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)

When creating a ROS Package diagram, Finish can be clicked even without modifying the file name. If you modify the first one (default.ros_package_diagram -> some_pkg.ros_package_diagram), then click finish, the second file generated (default.ros_package) keeps the name default.ros_package instead of having the same name as the .ros_package_diagram. This makes it impossible to compile without renaming the file by hand.

In most cases having the same name in the Goal parameter as in the Name parameter of the State makes sense. Therefore this can be done automatically. The user should only change it, if he wants something different.

this is system information and therefore should only be set in the system model, not in the node model.

If there is no Msg set in bride, it is still possible to Generate code, which cannot build.