Comments (6)
gsong
commented on June 23, 2024
@antonkulaga PRs are always welcomed.
from python-epo-ops-client.
amotl
commented on June 23, 2024
Dear Anton,
thank you for writing in. Having type hints would certainly be an improvement, on both aspects of QA and UX. Would you have the capacity to submit a corresponding patch?
With kind regards,
Andreas.
from python-epo-ops-client.
mattkeanny
commented on June 23, 2024
It would be great to enhance the library with type hints, indeed. However since the library still supports python 3.6 the type annotations are quite limited.
Python 3.7 allows the use of from __future__ import annotations (see docs) which would allow a more comprehensive set of type hints.
Question: Is dropping support for python 3.6 an option for this library?
from python-epo-ops-client.
gsong
commented on June 23, 2024
It would be great to enhance the library with type hints, indeed. However since the library still supports python 3.6 the type annotations are quite limited. Python 3.7 allows the use of
from __future__ import annotations(see docs) which would allow a more comprehensive set of type hints. Question: Is dropping support for python 3.6 an option for this library?
Seeing as Python 3.6 end-of-life happened on 2021-12-23, 3.7 EOL happened on 2023-06-27, I would say we can safely drop support for Python 3.6 and possibly even 3.7.
@mattkeanny Would you be up for making a PR with both type hints and for updating support for 3.8 and up only? This would be a major version bump.
from python-epo-ops-client.
mattkeanny
commented on June 23, 2024
Great. Will look into that. Thanks for considering.
from python-epo-ops-client.
dbolser
commented on June 23, 2024
What's the good news? I suspect ChatGPT could add type hints quite reliably... If nobody's working on it, I don't mind using CoPilot to make a PR...
from python-epo-ops-client.
Related Issues (20)
- SSL Error HOT 2
- 404 Client Error: Not Found for url: https://ops.epo.org/3.2/rest-services/published-data/publication/docdb/claims HOT 2
- `client.image` Method Fails to Retrieve Specific Document Pages
- TypeError: _make_request() got an unexpected keyword argument 'use_get' HOT 16
- Make invoking "response.raise_for_status()" optional
- Module epo_ops not found HOT 3
- Module epo_ops not found error HOT 1
- [Question] Is it possible to change the range of the results `published_data_search` ? HOT 2
- Negative delay when using Sqlite throttle middleware HOT 2
- Epodoc biblio url not found HOT 8
- Different results between espacenet and API HOT 1
- SQLite objects created in a thread can only be used in that same thread. The object was created in thread HOT 3
- 404 HTTP Error in Search HOT 1
- Is "description" supported by this client? HOT 6
- Future maintenance of repository and package HOT 7
- Next steps in maintenance and modernization HOT 2
- Fix test case `test_mock_quota_exceeded` HOT 3
- Replace Apiary tests with monkeypatch or in-process mockery HOT 5
- Throw an error if `original` is used with any incompatible method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-epo-ops-client.