iotaledger / gh-tangle-release Goto Github PK

Just a heads-up: you should pin axios at 0.18.1 until the vuln is resolved. Evil servers can DOS it with this technique:
axios/axios#1485

This was NOT resolved in 0.19

Explanation here:
lirantal/npq#116

The default node, https://nodes.iota.org:443, does not support remote PoW. We should specify another node instead (e.g. https://nodes.thetangle.org:443 or https://nodes.iota.cafe:443)

If you run the command and do not include an option that is required, then it will just return the help menu with no additional context. The help menu also does not note which parameters are required.

Would you be interested in allowing some of the CLI options to be specified through environment variables? Particularly the github token is convenient to pull in from the envs, and possibly the seed.

This is why our releases never published to the tangle:

tauri-apps/tauri#647

The gh-tangle-release action uses a node that doesn't support remote Proof-of-Work by default. This causes the action to fail.

Might be good to mention this in the readme...

Each time we run a unique hash is created so we have no way to tell if a particular tag has been published yet. Being able to consistently publish every tag for a release means that we need to be able to recover from a failure in the process.

If we have a search option (that can have a time element to it to limit the scope of search), we can search and check for a transaction. If it already exists, then we know we can skip publishing that particular tag. This would let us retry as needed without creating unnecessary tag+hash while attempting.