Code Monkey home page Code Monkey logo

Comments (6)

imhoffd avatar imhoffd commented on May 18, 2024 3

@DavidWiesner @tobika Please test release 0.3.0 which includes support for Android Adaptive Icons. Usage is in the readme: https://github.com/ionic-team/cordova-res/blob/master/README.md

from capacitor-assets.

imhoffd avatar imhoffd commented on May 18, 2024

I just tried playing around with adaptive icons in Cordova and ran into this issue: apache/cordova-android#694

Regardless, it looks like Cordova is supporting this feature now, so we can get this implemented. 👍

from capacitor-assets.

DavidWiesner avatar DavidWiesner commented on May 18, 2024

@dwieeb I had the same issue, but installing cordova@9 (like mentioned in your referenced issue comment) solved this for me

from capacitor-assets.

tobika avatar tobika commented on May 18, 2024

thanks, great work @dwieeb
the tool creates the image files as expected and changes the config, unfortunately I can't test yet if it works on the device because of cordova plugin dependencies I'm locked to cordova-android 7.1.4 (it should work from cordova-android 8 i guess)

one question, I used cordova-res --icon-background-source #0097a7 but the tool still expected the background png, is this normal? Thought it was to save space on the background png?

If only adaptive icons are packaged there is no problem for lower android versions?

from capacitor-assets.

imhoffd avatar imhoffd commented on May 18, 2024

If only adaptive icons are packaged there is no problem for lower android versions?

Good question 😅 I'm not sure how Cordova handles both types of <icon> definitions. Some testing is needed.

I used cordova-res --icon-background-source #0097a7 but the tool still expected the background png, is this normal?

No, that doesn't sound right. Can you make a bug report including output with --verbose turned on?

from capacitor-assets.

n00bsys0p avatar n00bsys0p commented on May 18, 2024

I used cordova-res --icon-background-source #0097a7 but the tool still expected the background png, is this normal?

No, that doesn't sound right. Can you make a bug report including output with --verbose turned on?

For me, the problem with supplying a hex colour as the background source was that the bash comment character is #, so passing it requires escaping the # symbol or wrapping the parameter in quotes. So cordova-res --icon-background-source \#0097a7 solved it for me ("#0097a7" would also be fine).

from capacitor-assets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.