ioki-mobility / kmp-lokalise-api Goto Github PK

See https://kotlinlang.org/docs/multiplatform-publish-lib.html

See https://ktor.io/docs/logging.html

https://docs.gradle.org/8.5/userguide/java_testing.html#sec:java_test_fixtures

Honestly I am not sure about the possibility in Kotlin Multiplatform projects 😅
Needs to be find out.

For build cache
More memory
...?

Use grouping for ktor dependencies... They will probably shipped all together anyways 🙃

I guess this would save some time as especially native targets have big dependencies.

The project doesn't require to publish each publication on a respective target host.
A macOSx86 runner can publish all of them.

See
https://developers.lokalise.com/openapi/
https://openapi-generator.tech/

npm install @openapitools/openapi-generator-cli -g
openapi-generator-cli generate \
    -i https://developers.lokalise.com/openapi/62bfa6905b5e2600520f71a0  \
    -g kotlin \
    -o /tmp/test/ \
    --global-property models \
    --additional-properties=library=multiplatform,packageName=com.ioki.lokalise.api

io.ktor.serialization.JsonConvertException: Illegal input: Unexpected JSON token at offset 459: Unexpected 'null' value instead of string literal at path: $.process.details.files[0].name_custom
JSON input: .....trings.xml","name_custom":null,"word_count_total":32,"key_co.....

Seems name_custom is not non-nullable.

This issue might goes hand in hand with #23

In #34 we added the ability to generate dokka docs.
We should run this, similar to our tests each time something changed (PR or push to main), and put the output to the GH acrtifacts.

com.ioki.lokalise:api:1.0.0? 🤔

• sign artifacts (added here: #39)
• add javadoc and source artifacts
  • javadocs (added here: #34)
  • source (sources will be added by default. See https://kotlinlang.org/docs/multiplatform-publish-lib.html#disable-sources-publication)
• adjust POM file to requirements (done here: #36)
• Add maven central repository to publishing (done here: #38)
• Create GitHub Action
  • To publish to Sonatype SNAPSHOT on main merge
  • To publish to Sontype staging release when tag pushed
• ...?

https://github.com/gradle/wrapper-upgrade-gradle-plugin

We have already tests in place, we should also run them 🤓

• Each push to main
• Each pull-request:

on:
  pull_request:
  push:
    branches:
      - main

As we (currently) support native (macOS, linux and windows) as well as JVM, we should run the tests on each runner.
Basically, we should run 4 tests in parallel:
linux -> linux-native
macos -> macos-native
windows -> mingw-native
linux -> jvm

Currently the library crash in case there is an api error. For example when we provide a wrong projectId or do not have the correct permissions with the apiToken.

This is because the library try to parse the json response to the desired model, but this fails as the returned json looks different...

Might go hand in hand with #2

We support Linux, Mac and Windows, but add the Darwin native engine.

We should fix this.
https://ktor.io/docs/http-client-engines.html