invent-ed / devleague--behavior-driven-shopping-list Goto Github PK

use the beforeEach() mocha hook to create new test instances for each test

see: https://github.com/edsperanto/devleague--behavior-driven-shopping-list/blob/master/js/shopping_list_item_test.js#L68

if other tests were added in the future, that mutate myList, this test may unexpectedly fail

add more test specs when the user

• create a new ShoppingListItem, set is_done to true, assert the desired output from render() is what you expect
• create a new ShoppingListItem, set is_done to true, set is_done to false, assert the desired output from render() is what you expect

around : https://github.com/edsperanto/devleague--behavior-driven-shopping-list/blob/master/js/shopping_list_item_test.js#L44

example:

tests/
  js/shopping_list_test.js
  js/shopping_list_item_test.js
  index.html
js/
  app.js ...
node_modules/
  ...
index.html

so that a user can go to http://localhost:8080/tests to run tests

ex:

  js/shopping_list_test.js
  js/shopping_list_item_test.js

relates to #11

this is a note that i want @edsperanto and @Chaz-C to be aware of

while the tests here https://github.com/edsperanto/devleague--behavior-driven-shopping-list/blob/master/js/shopping_list_item_test.js#L28-L38 will run as expected,
do note that these it() blocks may run asynchronously (in parallel).
so while the order of these tests do not matter because of the contents of these blocks (check, and uncheck).
be aware that you should not trust that one test will happen after the other.
in order to maintain confidence when testing in isolation, utilize mocha's beforeEach() hook, so that you can be certain that each it() block is running using a predictable test object (myItem).

to close this task, use beforeEach() to instantiate a new myItem instance each time

add more cases for when list is empty, add 1, add 1 and remove 1, add 2, add 2 then remove 1, add 1 then check() it, etc.

using dynamic values here could be problematic. what if myItem.is_done is null instead of the expected true or false values.
the render() method would return <li class='completed_null' ... and the tests will still pass, while this is not actually the desired behavior.

you should expect the li class to be 'completed_false'

(if it says anything except 'completed_false' make this spec fail)

at line : https://github.com/edsperanto/devleague--behavior-driven-shopping-list/blob/master/js/shopping_list_item_test.js#L42

using dynamic values here could be problematic.

relates to : #15

currently checking that myList.items.length is 0

this test would negatively pass if the class constructor looked like this

this.items = { length : 0 };

https://github.com/edsperanto/devleague--behavior-driven-shopping-list/blob/master/js/shopping_list_item_test.js#L60-L64