inveniosoftware-attic / invenio-app-demomarc21 Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 13.0 96 KB

Demo of an MARC21 based Invenio flavour.

Home Page: https://invenio-app-demomarc21.readthedocs.io

License: GNU General Public License v2.0

Python 77.56% HTML 10.80% Shell 11.63%

invenio-app-demomarc21's People

Contributors

Stargazers

Watchers

Forkers

dinosk nharraud lnielsen tiborsimko drjova biozzoli ioandr hjhsalo hachreak switowski piyushimraw cern-e-ternity jbenito3

invenio-app-demomarc21's Issues

sign up: error when the user tries to create a new account

Way to reproduce, click signup to app-ilis, fill the form up and click the "Sign up" button

Traceback (most recent call last):
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1997, in __call__
    return self.wsgi_app(environ, start_response)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/werkzeug/wsgi.py", line 660, in __call__
    return app(environ, start_response)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1985, in wsgi_app
    response = self.handle_exception(e)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1540, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_security/decorators.py", line 230, in wrapper
    return f(*args, **kwargs)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_security/views.py", line 118, in register
    user = register_user(**form.to_dict())
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_security/registerable.py", line 41, in register_user
    'welcome', user=user, confirmation_link=confirmation_link)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_security/utils.py", line 401, in send_mail
    mail.send(msg)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_mail.py", line 492, in send
    message.send(connection)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_mail.py", line 427, in send
    connection.send(self)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_mail.py", line 194, in send
    email_dispatched.send(message, app=current_app._get_current_object())
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/blinker/base.py", line 267, in send
    for receiver in self.receivers_for(sender)]
  File "/Users/user/.virtualenvs/invenio-first-week/src/invenio-mail/invenio_mail/ext.py", line 47, in print_email
    '{0}\n{1}\n'.format(message.as_string(), '-' * 79))
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_mail.py", line 381, in as_string
    return self._message().as_string()
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_mail.py", line 330, in _message
    msg['From'] = sanitize_address(self.sender, encoding)
  File "/Users/user/.virtualenvs/invenio-first-week/lib/python2.7/site-packages/flask_mail.py", line 105, in sanitize_address
    nm, addr = addr
ValueError: too many values to unpack

global: review sprint week 1 changes

Review all merged PRs from first week of sprint in demo site.

Make full install following the installation guide and running guide. You may need to make development installations of the corresponding modules.
Check every issue in DONE column. a) Have it been properly fixed (as in does it work for an enduser in the just installed demo site)?
Check if all modules have been released - if not make PRs for releases.

global: fix json schema validation when you import demo data

https://github.com/inveniosoftware/invenio-app-ils/blob/master/invenio_app_ils/cli.py#L52-L54

https://github.com/inveniosoftware/invenio-app-ils/blob/master/invenio_app_ils/config.py#L130-L131

theme: add mathjax?

tests: rate limiting of UI and REST endpoints

Write integration tests for rate limiting of UI and REST endpoints.

Moved from inveniosoftware/invenio-rest#71

records: add bibframe serializer

https://github.com/lcnetdev/marc2bibframe2

global: when debug is on, SQL statements are printed

Probably this needs to be switched off from in invenio-db

$ invenio demo init
....

Importing bibliographic records
2017-07-28 12:56:31,969 INFO sqlalchemy.engine.base.Engine SELECT CAST('test plain returns' AS VARCHAR(60)) AS anon_1
INFO  [sqlalchemy.engine.base.Engine] SELECT CAST('test plain returns' AS VARCHAR(60)) AS anon_1
2017-07-28 12:56:31,969 INFO sqlalchemy.engine.base.Engine ()
INFO  [sqlalchemy.engine.base.Engine] ()
2017-07-28 12:56:31,973 INFO sqlalchemy.engine.base.Engine SELECT CAST('test unicode returns' AS VARCHAR(60)) AS anon_1
INFO  [sqlalchemy.engine.base.Engine] SELECT CAST('test unicode returns' AS VARCHAR(60)) AS anon_1
2017-07-28 12:56:31,974 INFO sqlalchemy.engine.base.Engine ()
INFO  [sqlalchemy.engine.base.Engine] ()
2017-07-28 12:56:31,975 INFO sqlalchemy.engine.base.Engine BEGIN (implicit)
INFO  [sqlalchemy.engine.base.Engine] BEGIN (implicit)
2017-07-28 12:56:31,975 INFO sqlalchemy.engine.base.Engine BEGIN
INFO  [sqlalchemy.engine.base.Engine] BEGIN
2017-07-28 12:56:31,976 INFO sqlalchemy.engine.base.Engine ()

search: "Error: Validation error." when filtering with the "years" facet

Problem:
The years are displayed at the same time in a "range" widget ("years") and in a checkbox widget. Those two widget send a different query to the backend, either a range query or a multi-choice query. If the backend marked the "years" facet as a range, as it is the case in invenio-app-ils, the search will fail with an error message "Error: Invalid range format".

Temporary solution:
Create a custom temlate which will not show the checkbox widget.

i18n: french translation missing

global: make alpha release

records-ui: add export view

See https://github.com/zenodo/zenodo/blob/master/zenodo/config.py#L528-L535

Probably add this directly to Invenio-Records-UI

I would imagine the best would be to build a JavaScript which just connects to the REST API, however we can create a view which maps directly to the legacy 1.x views like in Zenodo.

records: add marcxml serializer

$ curl -H "Accept: application/marcxml+xml" http://localhost:5000/api/records/

should reply with MARCXML serialisation

Serializer
Example how to plug it https://github.com/zenodo/zenodo/blob/master/zenodo/config.py#L592-L593

Probably just have to be plugged in Invenio-MARC21

global: fix warnings when running in debug mode

$ invenio demo init
--------------------------------------------------------------------------------
WARNING in ext [/Users/lnielsen/envs/ils/lib/python3.6/site-packages/invenio_jsonschemas/ext.py:239]:
JSONSCHEMAS_HOST is set to localhost
--------------------------------------------------------------------------------
/Users/lnielsen/envs/ils/lib/python3.6/site-packages/flask_celeryext/app.py:33: UserWarning: Celery v4 installed, but detected Celery v3 configuration CELERYBEAT_SCHEDULE (use CELERY_BEAT_SCHEDULE instead).
  UserWarning

/Users/lnielsen/envs/ils/lib/python3.6/site-packages/flask_celeryext/app.py:33: UserWarning: Celery v4 installed, but detected Celery v3 configuration BROKER_URL (use CELERY_BROKER_URL instead).
  UserWarning

/Users/lnielsen/envs/ils/lib/python3.6/site-packages/flask_menu/__init__.py:341: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()
  expected = inspect.getargspec(f).args

/Users/lnielsen/envs/ils/lib/python3.6/site-packages/invenio_config/default.py:52: UserWarning: Set configuration variable SECRET_KEY with random string
  UserWarning)

/Users/lnielsen/envs/ils/lib/python3.6/site-packages/dojson/contrib/to_marc21/model.py:21: UserWarning: MARC21 undo feature is experimental
  warnings.warn('MARC21 undo feature is experimental')

/Users/lnielsen/envs/ils/lib/python3.6/site-packages/invenio_oaiserver/ext.py:150: UserWarning: Please specify the OAISERVER_ID_PREFIX configuration.default value is: oai:lnielsen-mbp.dyndns.cern.ch:recid/
  app.config.get('OAISERVER_ID_PREFIX')))

--------------------------------------------------------------------------------
WARNING in ext [/Users/lnielsen/envs/ils/lib/python3.6/site-packages/invenio_jsonschemas/ext.py:239]:
JSONSCHEMAS_HOST is set to localhost
--------------------------------------------------------------------------------
/Users/lnielsen/envs/ils/lib/python3.6/site-packages/flask_celeryext/app.py:33: UserWarning: Celery v4 installed, but detected Celery v3 configuration CELERYBEAT_SCHEDULE (use CELERY_BEAT_SCHEDULE instead).
  UserWarning

/Users/lnielsen/envs/ils/lib/python3.6/site-packages/flask_celeryext/app.py:33: UserWarning: Celery v4 installed, but detected Celery v3 configuration BROKER_URL (use CELERY_BROKER_URL instead).
  UserWarning

docs: clarify force_ssl is on by default

Documentation should be fixed, so that it's clear that they must run in DEBUG mode to have non-SSL site.

Find a way to easily disable force_ssl from flask-talisman

tests: integration tests for App-ILS

Simple test plan
As minimum one selenium test
Script to setup local virtualenv with all modules and run tests for each module.

Language
Keywords
...

pkg_resources.ContextualVersionConflict: (idna 2.6 (/Users/drjova/.virtualenvs/invenio-first/lib/python2.7/site-packages), Requirement.parse('idna<2.6,>=2.5'), set(['requests']))