Code Monkey home page Code Monkey logo

Comments (6)

yochannah avatar yochannah commented on June 19, 2024

I think this happens when the features don't overlap the original regions on both sides.

from bluegenes.

yochannah avatar yochannah commented on June 19, 2024

Correcting the min-max stops the labels overflowing, but it becomes clear that the math is out somewhere for these.

For flymine's third defaut region there should be three chunks of different overlapping features. The features marked below in yellow and purple overlap almost perfectly, as do the blue and green, hence why there are 5 overlaps in total but only three separate chunks should be seen on the diagram, assuming I've done my math correctly. (Please yell at me if I haven't).This is not to scale, I did it in a paint program, and the regions should all be about the same length

image

We also need to remove or reduce the blur, but this doesn't fully fix the problem. Short term: I'm removing the graphs from the display.

Longer term: make sure the clculations are fully tested, esp. for boundaries and scenarios where there aren't overlaps on both sides of the region.

from bluegenes.

yochannah avatar yochannah commented on June 19, 2024

ok, removing blur and allowing the min-start and max-end values to be part of the original set has made things better, but I don't think that the left two should overlap :/

image

from bluegenes.

sehgalvibhor avatar sehgalvibhor commented on June 19, 2024

@yochannah : How can I replicate this on the dev environment?

from bluegenes.

yochannah avatar yochannah commented on June 19, 2024

@sehgalvibhor Good question! I had to dig a little to remember (note to self: always include file locations when you make tickets!)

Uncomment this line: https://github.com/intermine/bluegenes/blob/dev/src/cljs/bluegenes/pages/regions/results.cljs#L82 that should do it!

P.S. sorry for the slow reply, I"ve been out of the office travelling! :)

from bluegenes.

yochannah avatar yochannah commented on June 19, 2024

this issue is no longer valid - we removed the graph since it wasn't valid

from bluegenes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.