insidersbyte / react-markdown-renderer Goto Github PK

Hi,

I've made a proof of concept real quick because I needed to ship in production with the ++underlined words++ that you can check here : https://github.com/vizeat/react-markdown-renderer/commit/9d2852e0cd14d2ce27ddf151d90e323c00a0e849

The idea is simply to make it possible to specify both the options and the preset when instantiating Remarkable (see here for the relevant code in Remarkable's code base)

Is that something you would consider ? Would you like me to make a PR for that ?
In my case I took the liberty to rename options to remarkableOpts to make it obvious what it is for and avoid the weird options.options or variable renaming at validation/instanciation time. Is that something you would rather avoid ? Doing so would likely require a major version bump due to the breaking change.

Another solution would be to have 2 props passed to the component (options like now and preset) but I'm not found of polluting the parent component with props specific to the internal setup of the child component.

Thanks !

There is a security vulnerability with marked https://nodesecurity.io/advisories/marked_content-injection

Hello,

I'm currently working on a fork that would allow modifying (enabling/blocking) the rules on the remarkable instance. I have it working, but am having difficulty updating the tests. Do you have any advice on this?

You can see my branch here: https://github.com/bradbumbalough/react-markdown-renderer/tree/bb/customize-ruler.

Thank you!

Remarkable should not be instantiated inside the render method and should instead be outside function declaration, but the tests were failing and the security flaw needed fixing.

See https://github.com/jonschlinkert/remarkable#plugins