Code Monkey home page Code Monkey logo

inscryb-markdown-editor's People

Contributors

7upcat avatar adam187 avatar adriaanzon avatar arduanov avatar boristhuy avatar brondsem avatar cbadke avatar cwharton avatar danabrey avatar dependabot[bot] avatar fabiankoestring avatar fraserredmond avatar frm avatar ggtmtmgg avatar grestorn avatar ionaru avatar jamiewohletz avatar jonatanklosko avatar jonyhayama avatar kle-roy avatar lukasz89 avatar maclover7 avatar nofxx avatar qumberhussain avatar ryan-codingintrigue avatar trwired avatar vladson avatar wescossick avatar wesleym77 avatar whiterm avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

inscryb-markdown-editor's Issues

[Question] Feedback on downstream library

I'm submitting a...

  • Bug report
  • Feature request
  • Announce?

Reproduction steps

n/a

Version information

Browser type and version:
InscrybMDE version: 1.11.6

vue-inscrybmde

I forked vue-simplemde and updated it to use inscryb-markdown-editor. At this point its a straight fork, no enhancement, other than those built directly into inscryb. Looking for thoughts and feedback. https://github.com/dantrevino/vue-inscrybmde.

Since there is no slack/twitter/whatever, I thought i'd mention it here.

Cheers,
Dan

How do you guys develop?

Just wondering, how exactly do you guys develop this thing? There's got to be a faster way than waiting 7 seconds for gulp to do its thing every time I change a bit of code. I keep reading online about gulp serve which is a task one must make somehow, but I don't get it.

isPreviewActive() and isSideBySideActive() not working?

I'm submitting a...

  • Bug report

It seems that in both SimpleMDE and InscrybMDE, functions isPreviewActive() and isSideBySideActive() always return false regardless of the actual state.
Given that the implementation of these functions looks up parent HTML elements and checks for CSS classes on them, maybe it finds the wrong elements on which it checks for the appropriate class names?

Reproduction steps

Add a button to the menu such as:

{ name: "preview", action: function(e) { e.togglePreview(); console.log(e.isPreviewActive());}, className: "fa fa-pencil no-disable", title: "Toggle Edit", default: false },

This will always say false, while for isFullscreenActive() (which does not rely on CSS class names) it works correctly.

Version information

Latest (InscrybMDE version 1.11.4 and SimpleMDE version 1.11.2)

Thanks!

update npm version

I'm submitting a...

  • Bug report
  • [ x] Feature request

Reproduction steps

  1. npm install vue-inscrybmde --save

Version information

Browser type and version: all
InscrybMDE version: 1.11.16

can we get a new release and npm updated? I'd love to use some of the newer upstream features.

Relation to EasyMDE

Hi, I've been looking for a (maintained) replacement to SimpleMDE and found this and EasyMDE - what is the relation between the forks? I would really like to have my cake and eat it all :D

Pressing "space" deleted text on Firefox mobile

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

The form doesn't work on Firefox mobile. Specifically text can be typed, but the placeholder text does not disappear so text is typed over it, and when you press space the previously typed text is removed. Otherwise buttons and formatting appear to work, and no console messages appear when Firefox is put into debug mode.

  1. Type any text in the markdown form
  2. Press space

Version information

Browser type and version: Firefox 63.0a1 (nightly 2018-08-31) Android
InscrybMDE version: 1.11.4

H2 and H3 icons not working

I'm submitting a...

  • Bug report

Reproduction steps

  1. ... Add H2 and H3 buttons to the toolbar
  2. ... Icons don't load

Version information

Browser type and version: Chrome 66.0.3359.117
SimpleMDE version: 1.11.3

image

Update marked dependency

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

  1. npm audit or yarn audit in any project using inscrybmde will show "1 moderate severity vulnerability", namely marked

Version information

Browser type and version: N/A
InscrybMDE version: 1.11.6 (latest)

Fix

The fix is pretty simple: upgrade the marked dependency to ^0.6.2.

IE11 - mouse slection not working

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

  1. Open browser.
  2. Type several paragraphs.
  3. Try selecting one of the paragraphs in IE11.
  4. Kick yourself in the nutsack.
  5. Load up https://simplemde.com/ in the same browser
  6. Successfully select any paragraph you want.
  7. Apply ice to nutsack.

Version information

Browser type and version: IE 11.471.17134.0
InscrybMDE version: any?

Support for YAML Header?

I'm submitting a...

  • Feature request

Reproduction steps

Il try to use a tagging like feature with this editor. This works by using YAML in CommonMark. For example you can insert the following at the beginning of a markdown file:

---
tags: coding php css javascript
...

to add the tags coding, coding, php, css, javascript as tags. All of the separated by space character. Is there a way to support such a standard notation or at least to to not render such a part directly in the preview? I need this only in the editor visible.

Screen Readers are unable to track cursor in textarea

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

  1. Type text into a MDE textarea, possibly with new lines.
  2. While any screen reader is on, such as NVDA for Windows, VoiceOver on Mac or iOS, use the arrow keys to navigate around.

Result: The textarea is often detected as being empty, characters are not announced while the cursor moves.

Expected result: lines and characters are announced as the cursor moves.

Version information

Browser type and version: any
SimpleMDE version: any

Editor prevents form submit using Enter key while typing in other inputs

I'm submitting a...

  • Bug report

Reproduction steps

JSFiddle

  1. if the form has other input elements other than the editor, pressing the "Enter" key on any of these elements totally ignored.
    the editor somehow set the focus on the first icon in the toolbar even if you didn't set the cursor inside the editor it self.

Version information

Browser type and version: Chrome v88.0, Firefox v85.0
InscrybMDE version: 1.11.6

Issues with required attribute

Having an issue with required fields as the browser can't focus them after they have been replaced:

<textarea name="text" cols="40" rows="10" class="form-control" title="" required="" id="id_text" style="display: none;"></textarea>
var simplemde = new InscrybMDE({
        element: $("#id_text")[0],
        hideIcons: ["heading"],
        showIcons: ["heading-2", "heading-3"]
    });

image

Adding novalidate to the form works around the issue.

[Question] What were the changes since the fork?

I'm new to this repository and I do not understand what change from Simple Markdown Editor ...
In EasyMDE exist a changelog in the README File but not in Inscryb MDE.

Changes include:
FontAwesome 5 compatibility
Guide button works when editor is in preview mode
Links are now https:// by default
Small styling changes
Support for Node 8 and beyond
Lots of refactored code
Links in preview will open in a new tab by default

Add possibility to tag people with @

I'm submitting a...

  • Bug report
  • Feature request

Version information

Browser type and version: All
InscrybMDE version: Latest

I wanted to know if you're thinking about putting mentions in this project.
Thank you

How to disable load from avtosave on load

Nice work!

I'm submitting a...

  • Feature request

Reproduction steps

I use the mde editor here: https://github.com/recoilme/tgram
Autosave - enabled
Then i press edit on an article - i fill data from server to textarea
But it replaced with autosaved data (if present)
I don't want to disable autosave, but I want on the first load don't load autosaved text

Version information

Browser type and version:
SimpleMDE version: latest

Force sync does not update textarea valid/invalid status

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

https://jsfiddle.net/hv352zf8/

Notice that in the example if you remove the inscrybmde the CSS changes the button color. However, if you set a markdown editor on the textarea, even with forceSync as shown in the readme, the button text does not update.

Version information

Browser type and version: Firefox 62.0a1
SimpleMDE version: 1.11.3

Possible to edit without showing markdown ?

It would be great to have a mode, like preview - but with editing.

Some of my users are non-technical, so I could show them a version of the editor that doesn't have the markdown available.

change default InputStyle

I have the problem that CodeMirror's default InputStyle on mobile devices ("contenteditable") creates several unintended issues. I prefer it to use "textarea" always.

Unfortunately, this option cannot be changed after the editor has been instantiated. I can't figure out how to change CodeMirror's default setting and it also doesn't seem to be possible to forward options into CodeMirror when instantiating inscryb as far as I can see.

How can I get around this problem?

Small issue when creating a quick draft

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

When creating a Quick Draft the notification appears noting the draft has been created, however the draft itself does not appear in Page Drafts without a forced refresh of the page by the user.

Version information

Browser type and version: Firefox Quantum 61.0.2
InscrybMDE version:

Event for FullScreen / Side-by-side

When opening Fullscreen or side-by-side, my site's menu bar is obstructing the top part of the editor.

I want to resolve that problem by hiding the menu bar as soon as the editor switches to full screen and turn it back on as soon as the full screen mode is left.

I looked through the list of events but I can't find anything for that. Is there a way to achive this?

Thanks & best regards

Toolbar still gets wiped when setting a custom button?

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

N/A

Notes

Came here from a thread complaining of the same thing for SimpleMDE where the toolbar buttons get wiped when you set a custom one. It seems incrybMDE has not handled that yet, either?

      toolbar: [
        {
    			name: "custom",
    			action: function customFunction(editor){
    				// Add your own code
    			},
    			className: "fa fa-star",
    			title: "Custom Button",
    		},
      ],

Also, as a side note, moving to <button> makes a dark theme look uggo.

Add `class` to toolbar buttons

I'm submitting a...

  • Bug report
  • Feature request

Request

Add class with button names to toolbar buttons.

Current version is:

<div class="editor-toolbar">
  <button title="Bold (Ctrl-B)" tabindex="-1"><i class="fa fa-bold"></i></button>
  ...
</div>

I'd like to propose we simply add a class, like this:

<div class="editor-toolbar">
  <button title="Bold (Ctrl-B)" class="editor-button-bold" tabindex="-1"><i class="fa fa-bold"></i></button>
  ...
</div>

This would allow CSS styles to be applied on a single button, eg. A save button shown in a different color when it detects changes that nees to be saved.

I'm more than happy to submit a Pull Request, I'm opening this issue just to check if it is OK to do so :)

Please tag releases or keep a changelog

I'm submitting a...

  • Bug report
  • Feature request

Please keep a changelog or tag releases. I am trying to figure out if an issue was fixed in the release I'm using, but it's hard to associate commits in the repo with actual releases. Having tags (or branches depending on your workflow) for each release, or a changelog that lists the features of each release would be very helpful.

Thanks for all the work you've put into this!

Text-Alignment Custom Functions

[X] Feature Request / Code Assistance

I know Markdown doesn't have text alignment, but I did see this editor does allow custom functions. So in theory I could add 3 buttons, left/center/right align. But I have no idea what the function code would be to add a class to the end of the line that would support text alignment.

I know in Markdown by adding { .text-center} to the end of a line, it will add the class needed to center the text. The function would have to add this text when clicked/enabled, and remove it if disabled. And if possible, to have the icon selected and not selected appropriately.

Any help in the right direction would be appreciated.

Clicking on preview hangs

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

  1. ...
  2. ...

Version information

Browser type and version: Chrome or FF
SimpleMDE version: unscrybmde 1.11.3

When I click on preview on a screen with some markdown data on it, the screen just says loading and hangs there. A am doing something wrong?

Keyboard access

Hello!
It's really good to see accessibility improvements toward keyboard access (buttons instead of links) but I've noticed there is still one thing missing to make it fully happen - tabindex in below snippet is deliberitely set to "-1":

Looks like quick fix but maybe there is any specific reason for it?

Kind regards,
mp.

Setting for negativeTabIndex has no effect

I'm submitting a...

  • Bug report

The setting for negativeTabIndex does not change the tab Index setting for the buttons, this is always -1.
This feature was added here #24

Reproduction steps

See this JSFiddle: https://jsfiddle.net/s62m4gor/
Changing negativeTabIndex does not change the resulting tabIndex of the bold button.

Version information

Browser type and version: Chrome 116.0.5845.110 / Safari 16.6 (18615.3.12.11.2)
InscrybMDE version: 1.11.6

Thanks for the help.

[TOC] seems to be ignored

Hi there. Im not sure if i miss something, but if my markdown file has a [TOC] at the beginning or somewhere else, it generates a table of contents at that place directly from the headlines in my other markdown applications. But not so here. Is there some way how i could get this feature here working to?

Editors fail to load text if hidden on pageload

If the textarea/editor is inside a tag which is not open, the contents of the edit area will be blank. Clicking inside the edit area will force an update and render the initialValue properly. If the edit box is in a tag which is open is behaves properly. This is true if you set either the text inside the textarea, the initialValue, or both. Setting the initialValue and a placeholder still shows a blank box.

If there is no content then the placeholder text will display properly in all cases.

detail_closed_bug.html.txt

Autosave should accept callbacks

I'm submitting a...

  • Bug report
  • Feature request

Description

It would be great to have a way of changing autosave's behavior. like for example to make it persist data to an API.

Feature request: Grammerly support

I'm submitting a...

  • Bug report
  • Feature request

Version information

Browser type and version: Chrome 76.0.3809.132
InscrybMDE version: 1.11.6

I'm not sure if this is possible in any way, so feel free to close this issue if it's not.

I'm using the editor to write blog posts and would love to be able to use Grammerly directly into the editor. In order for Grammerly to work, it needs to see a textarea with content which this editor isn't. Is there some kind of way we can trick Grammerly into picking up the text that's written and being able to suggest changes?

If you have any pointers about possible solutions I also don't mind putting something together and creating a PR, but I'm kind of clueless about a possible solution. Your time and effort are very much appreciated!

Spellchecker language

Hi,

I'm using vue-simpleMDE for my project and i found your package, i'm interested by it and happy to know that someone continue the work.

So i would like to know if you've found a way to integrate spellchecker in other language than english, if not i'll do it in the next week / month (pass option to typo.js, search for common dictionnaries in other language, integrate it in SimpleMDE / InscrybMDE).

Let me know if you are interested and like tou see i really need a spellchecker ;) (i'm french)

Also, it would be a great thing if you could briefly summarize the change you made to SimpleMDE.

Thanks.

Want to specify language of tooltips and statusbar

I'm submitting a...

  • Bug report
  • Feature request

Hello guys,
I'm using this project in a project for a customer of mine. Since my customer speaks only german, I have to ask if it's possible to change the language. Actually it's english only. Maybe it is possible to add a option locale to the options object.

Bests,
MetalCar

Shortcut for the custom function

I'm currently using SimpleMDE, but looks like its dead. Going to move to inscryb if it would be possible to assign shortcut to a custom function

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.