inpercima / run-and-fun Goto Github PK

What did you think about this branch? https://github.com/inpercima/run-and-fun/tree/application-config-default.
Is there something we could use in the master?

Currently the login page is shown when you logged in. It will be better if after the login the dashboard (dash page) will be shown.

So the login should be saved in cookies I think. What did you mean?

FYI @sepe81

While I was working on another project, I found bowercopy (https://www.npmjs.com/package/grunt-bowercopy). It copies just the necessary files into the build folder only.

bowercopy: {
      dist: {
        files: {
          '<%= build_dir_js %>': 'angularjs/angular.min.js'
        }
      }

In log output the names should be visible.

Found this article: http://solutionoptimist.com/2013/10/07/enhance-angularjs-logging-using-decorators/

These two rules are currently checked with warnings. We have to discuss how we handle these.

I updated the master and this works. After merging and updating the branch I got this error.
Clean and revert does not work.

Waht could be the problem?

In some cases it is better to have labels to filter activies. For running like mountain or flat. So it is possilbe to compare activities.

It is not neccessary to use bower so we can remove the dependencies.

• name of pages in js (plural?)
  • label: Activities, html: activities, controller: ActivityController, service: ActivityService -> should be renamed to Activities
  • label: Graphs, html: graphs, controller: GraphsController, service: GraphsService -> check ok
• what about subdirs in js
  • subdirs for page like 'activities', 'dash' or for type 'controller', 'service' -> I prefer for page
• what about subdirs in html
  • subdirs for page like 'activities', 'dash' or for type like 'pages', 'includes' -> I prefer for part
    #49

At the moment the selection "All years" in activities and graphs won't work. The properties send to the server are not set correctly.

While reading some lines about the topic validthis I desided to change back to ignoreline because validthis applies to the hole function not only to the next line.

There exists a lot of style guides like:
https://docs.google.com/document/d/1XXMvReO8-Awi1EZXAXS4PzDzdNvV6pGcuaF4Q9821Es/pub or http://www.johnpapa.net/angular-app-structuring-guidelines/.

I would use a mixture of several guidelines. Let us discuss about this.

There are some issues they can be fixed. Code climate use eslint. We should check them and either use eslint or configure jshint/jscs.

spring boot provides various options for environment specific configuration

see: http://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html

At the moment we use spring-boot 1.4.6. When updating to 1.5.3 there is an exception when calling findAllByTypeOrderByDateDesc

10:34:50.689 INFO  n.i.r.service.RunAndFunServiceImpl:196 - {
  "bool" : {
    "must" : {
      "bool" : {
        "should" : {
          "term" : {
            "type" : "running"
          }
        }
      }
    }
  }
}
10:34:51.003 WARN  o.s.w.s.m.s.DefaultHandlerExceptionResolver:407 - Failed to write HTTP message: org.springframework.http.converter.HttpMessageNotWritableException: Could not write JSON document: (was java.lang.NullPointerException) (through reference chain: org.springframework.data.elasticsearch.core.aggregation.impl.AggregatedPageImpl["facets"]); nested exception is com.fasterxml.jackson.databind.JsonMappingException: (was java.lang.NullPointerException) (through reference chain: org.springframework.data.elasticsearch.core.aggregation.impl.AggregatedPageImpl["facets"])

Replace cdn access with local managed libraries und reduce page load to a minimum.

Use /* jshint validthis: true */ before instead of // jshint ignore:line behind code.

Hey, what exactly is xmlRequestProvider? Cant find infos about that anywhere.

Error: TypeError: Cannot read property 'debug' of undefined

It seems that the pie chart will not load correct if the internet connect is not stable enough. Sitting in the train with hotspot it loads the graphic either not or not completely.

• navigation instead of tabs
• global login, first login to get access
• update form design
• responsive design

There exists an interesting plugin on https://github.com/srs/gradle-grunt-plugin to run grunt tasks within gradle.

I can integrate it but I still have some gaps in gradle to run the tasks. In the best case it should simply run grunt build after the gradle build. According to the description on the page the plugin could also run npm install.

Can you @sepe81 give some information to do integrate it right?

After login to runkeeper it's possible to index all activities through the given rest api. Every activity gets dowloaded and inserted/updated into elasticsearch (ES). It would be better to fetch only new activities after the first indexing has taken place.

After rendering the graphs in the corresponding panel there is a minimal horizontal layout enlargement. It's not new and existed even before the new layout.

@inpercima, any idea how to fix this minor issue?

It should be possible to activate an deactivate the debugmode by an paramter in the url. Default should be false - no debugmode. #46