innocarpe / actions-slack Goto Github PK

before node12 is removed : ref https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

#8

There is a misconfiguration in the github actions on this repo, and as a result the actions are failing.

It would be nice if that was fixed so we could look to this repo as an example of how to configure our own actions.

Hey Innocarpe!

This action is definitely one of my favorites when it comes to slack notifications, but I feel that it is lacking in one key area: the ability to specify a slack channel. Many other actions that simply use a webhook allow for this customization.

While I do not know typescript and do not want to offend you with a lousy PR, I was looking around and I think that something like this might work:

this.webhook = new IncomingWebhook(process.env.SLACK_WEBHOOK_URL, {
      channel: 'process.env.SLACK_CHANNEL',
    })

Thanks in advance!

We're using this action on our deploys and I just noticed the following warning within the github action UI:

Check warning on line 1 in .github

@github-actions
github-actions
/ Deploy to Aptible staging

.github#L1
Unexpected input(s) 'status', valid inputs are ['success_text', 'failure_text', 'cancelled_text']

Here's how we've set up the action:

      - name: Announce on Slack
        if: ${{ always() }}
        uses: innocarpe/actions-slack@v1
        with:
          status: ${{ job.status }}
          success_text: 'Deploy to Aptible staging succeeded :smile:'
          failure_text: 'Deploy to Aptible staging failed :frowning:'

Although the line it's warning about is wrong, it does appear that the warning is coming from this package. Any idea why it's not recognizing the status key? To be clear, the Slack notifications are otherwise working as expected.