inniti / fronnt Goto Github PK

Describe the bug
Enums defined in the graphql schema are transpiled into typescript type definitions.
For the purpose of mapping responses from a connected shop into one of those enums the types are not feasible at all.
An example is the MeasurementUnit enum, that will get transpiled to

export type MeasurementUnit =
  | 'ACRE'
  | 'ARES'

this isn't very usable when hydrating the article.salesUnit.name field from the response of a connected shop, as this will always be a String, which isn't allowed as MeasurementUnit.

Proposal is to either find a way that enums from the graphql schema are transpiled to enums in typescript or always add the String to those enums, which makes them useless.

The core GraphQL spec only has the Int, Float, String, Boolean and ID scalar types by default.
More specific scalar types would help to better describe and validate data.

See https://www.graphql-scalars.dev/docs#why for additional motivation.

We could integrate https://www.graphql-scalars.dev/, so that we don't have to implement the types by our owns.

To prevent invalid type definitions in the schema, we could setup a github action which validates the schema each time it is changed.

#6