Code Monkey home page Code Monkey logo

bower-locker's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bower-locker's Issues

bower-locker is using potentially outdated repo links

If a Bower dependency is downloaded via http, it is saved to .bower.json within that folder. If the link is later updated to git in the bower-locker.bower.json file, bower-locker will instead use the original value saved in .bower.json. Thus continuing to use the http repo link.

Bower-locker gets directory location from .bowerrc

Would be nice if bower-locker could read the bower config .bowerrc file and find there bower_components directory variable.

{
  "directory": "vendor/bower_components"
}

Right now it throws an error because the components path is hardcoded.

env: node\r: No such file or directory

bower install fails

Hey,

great work on the locker. im getting this error on "bower install"

bower ENORESTARGET URL sources can't resolve targets

i have replaced all "https://" with "git://" in bower.json and removed bower_components dir but still no luck. Can you help?

Cheers.

Check the .bowerrc file

The lock read only the bower_components/ folder, but it's possible configure other folder to receive the packages in the configuration file.

Ignore relative path resolutions

Firstly, thank-you so much for this project. I cannot overstate this enough.

When I have a dependency that is a relative path on my filesystem, bower-locker converts that resolution to an absolute path followed by #undefined. This results in ENORESTARGET File system sources can't resolve targets on a new bower install.

I expect bower-locker to ignore dependencies that are relative paths.

When some packages don't have `_resolution` property, locker will fail.

Hi @MaKleSoft,
This is a great tool, but the first time I'm using and I faced an error, I had this in my bower.json file's devDependencies property:
"devDependencies": { "sinon": "http://sinonjs.org/releases/sinon-1.12.1.js", .... }
So bower-locker failed because that in the .bower.json file of this package there will be no _resolution property.
I had to open the source code and do some fixes and did some changes too, please correct me if this is not a good way to go:

  1. Replaced the old way of setting dependency version value to git URL and the release number with setting only the release number as it's enough to be able to install a packages.
  2. Added a check for commit variable as it may not exists for some packages.
  3. Added a check that if release number (extracted from .bower.json of the package) is not valid version number (using semver npm library to check) then set the original value from the old bower.json file we read.
  4. If package exists in both dependencies and devDependencies then fix the release number for both (the old way was to delete devDependencies now we don't).

It's working for me now, don't know if it'll break with some other special cases.
Here's my fork: https://github.com/AbdoDabbas/bower-locker

difference when using bower-locker for Swiper 2.7.6

Swiper 2.7.6 seems to be differently used by bower-files, Angular.js (1) and others when it is locked down. It looks like there is a different commit hash used for 2.7.6?

With the normal setup it works (unlock).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.