• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base application
  • ignite the cli
  • ignite generated code

npm WARN deprecated [email protected]: cross-spawn no longer requires a build toolchain, use it instead!
npm WARN deprecated [email protected]: this package has been reintegrated into npm and is now out of date with respect to npm

When using <ProgressiveImage /> without an explicit width/height, the component throws an error:

ExceptionsManager.js:76 Unhandled JS Exception: Cannot read property 'width' of undefined

Code in question is:

https://github.com/infinitered/ignite/blob/master/ignite-base/App/Components/ProgressiveImage.js#L66-L70

  render () {
    return (
      <View
        width={this.props.style.width}
        height={this.props.style.height}
        backgroundColor={'#CCC'}
      >
      {this.handleImage()}
      </View>
    )
  }

Make sure verify the following before submitting an issue.

• Issue does not already exist
• You have example code or some other reproduce experiment that we can verify

...this boilerplate is awesome, thank you for sharing it guys 👍

In a large project, the newclear command can appear to hang while it removes all your node modules. It would be great if we could show a spinner or some other activity indicator while that portion of the command is running (npm i has it's own, so we don't need to worry about that portion) so that users don't think the command has failed.

I feel like that giant wall of text is a bit too much when running ignite n MyApp. Would you be open to using a spinner instead?

Warning in master for 0.25.1 reported to facebook: facebook/react-native#7394

Make sure verify the following before submitting an issue.

• Issue does not already exist
• You have example code or some other reproduce experiment that we can verify

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base application
  • ignite the cli
  • ignite generated code

Let's add Steve's excellent developer library Reactotron

@skellock deserves the credit for adding these two beautiful Android scripts

    "android:logcat": "$ANDROID_HOME/platform-tools/adb logcat *:S ReactNative:V ReactNativeJS:V",
    "android:shake": "$ANDROID_HOME/platform-tools/adb shell input keyevent 82"

Rather than stealing his thunder ⚡ I made this ticket so he can do it.

When through the fresh install process tonight.

Looks like we'll need make sure rnpm is installed properly and is up-to-date.

The I18N library wasn't able to be linked properly.

After upgrading and re-linking, the I18N library was found.

as of right now, if we modify code, we need to log in to semaphore and modify the checks/balances as well. We should move all this to an npm script and call that. This allows for local testing, and test modifications.

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base application
  • ignite the cli
  • ignite generated code

I think what I came up with for one of our projects would be a reasonable starting point:

Hiya! So you think it's broken or missing a feature eh?

Welllllll, it just might be. Do me a favor and check the following:

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

Hello,

Looks like the cli has some errors while trying to create a new project:

Everything runs fine until

o run your app on iOS:
   cd
   react-native run-ios
   - or -
   Open  in Xcode
   Hit the Run button
To run your app on Android:
   Have an Android emulator running (quickest way to get started), or a device connected
   cd
   react-native run-android
Cloning into '/usr/local/lib/node_modules/generator-react-native-ignite/app/templates'...
Warning: Permanently added the RSA host key for IP address '' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

events.js:154
      throw er; // Unhandled 'error' event

AssertionError: Trying to copy from a source that does not exist: /usr/local/lib/node_modules/generator-react-native-ignite/app/templates/ignite-base/README.me

Looks like that folder only has an "index.js" file (after a fresh install of the cli)

Seed App also looks like it is missing some files

Any Idea?

thanks!

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

Had an idea:

As of right now making a pattern library/style guide causes a good bit of merge conflicts on any project, since everyone has to touch the AllComponents screen.

My thoughts, are, each component export an example render. Which is a vanilla example usage of the given component.

Then, we actually do File IO on all files inside the components folder. We iterate over the files and require them. IF they contain an example function, we call and render it.

What does this solve? Merge conflicts, enforcing example usage in component, portability, and lastly elixir like "test usage" living with app code.

I find myself doing this very often:

  title: {
    fontFamily: Fonts.bold,
    fontSize: Metrics.fonts.medium,
    color: Colors.charcoal
  },

I think it would feel a lot "cleaner" to do this:

  title: {
    fontFamily: Fonts.bold,
    fontSize: Fonts.size.medium,
    color: Colors.charcoal
  },

It would be a relatively easy change. When i thing of "font size" i don't think of the "metrics" object, i think of the "font" object.

Make sure verify the following before submitting an issue.

• Issue does not already exist
• You have example code or some other reproduce experiment that we can verify

YellowBox is not tied to DebugSettings

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base application
  • ignite the cli
  • ignite generated code

The current Styles directory doesn't scale well. Let's move those files to a new home which reflects the ownership.

/App/Components/Styles/
/App/Containers/Styles/

These components & containers styles are only used by 1 file anyway.

Thanks @GantMan and @kevinvangelder for illuminating this problem.

I'll tackle this one.

rnpm can include fonts if they are in an imported package... I'm interested in a way to use that, or other means to include fonts in Android/iOS from an command in the current project.

Suggested folder structure is two folders one for the ignite-base and one for theignite-generator

Need to make our splash down page.

as of right now, you have to run react-native-ignite when we want to add ignite as the CLI. It should wrap yeoman if possible. If it cannot, report a second ticket.

Installation is not possible and gives the errors listed below.

$ node -v
v5.10.1
$ npm -v
3.8.3

npm install -g react-native-ignite

npm WARN deprecated [email protected]: this package has been reintegrated into npm and is now out of date with respect to npm

> [email protected] preinstall /usr/local/lib/node_modules/.staging/react-native-ignite-a8026b56
> npm i -g yo

npm WARN deprecated [email protected]: this package has been reintegrated into npm and is now out of date with respect to npm
/usr/local/bin/yo -> /usr/local/lib/node_modules/yo/lib/cli.js

> [email protected] postinstall /usr/local/lib/node_modules/yo
> yodoctor


Yeoman Doctor
Running sanity checks on your system

✔ Global configuration file is valid
✔ NODE_PATH matches the npm root
✔ Node.js version
✔ No .bowerrc file in home directory
✔ No .yo-rc.json file in home directory
✔ npm version

Everything looks all right!
/usr/local/lib
└── [email protected] 

/usr/local/lib
└── (empty)

npm ERR! Darwin 15.3.0
npm ERR! argv "/usr/local/Cellar/node/5.10.1/bin/node" "/usr/local/bin/npm" "install" "-g" "react-native-ignite"
npm ERR! node v5.10.1
npm ERR! npm  v3.8.3
npm ERR! path /usr/local/lib/node_modules/.staging/abbrev-ec010306
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/usr/local/lib/node_modules/.staging/abbrev-ec010306' -> '/usr/local/lib/node_modules/react-native-ignite/node_modules/abbrev'
npm ERR! enoent ENOENT: no such file or directory, rename '/usr/local/lib/node_modules/.staging/abbrev-ec010306' -> '/usr/local/lib/node_modules/react-native-ignite/node_modules/abbrev'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! Please include the following file with any support request:
npm ERR!     /data/workspace/npm-debug.log
npm ERR! code 1

The output suggest in the middle that /usr/local/lib shall be empty, but thats not true.

@GantMan was saying he didn't like our Types.js structure how we're repeating keys & values.

Facebook solves this with keyMirror.

What are the thoughts on this? Good? Bad? Unclear? Just inventing another reason to use Ramda?

// createTypes.js
export default R.pipe(
  R.trim,
  R.split('\n'),
  R.map(R.pipe(R.trim, R.toUpper)),
  R.map((x) => [x, x]),
  R.fromPairs
)

// Our new Types.js
import createTypes from './CreateTypes'

const types = `
push
pop
login_success,
login_request,
login_failure
`

export default createTypes(types)

Ramda playground to riff: http://goo.gl/KIVfQ5

What is the right way to propose new component for ignite? or if we want to keep ignite to base class only. how should I integrate ignite with https://github.com/gcanti/tcomb-form-native separately and it will compatible with ignite for future upgrade?

• [x ] ignite base application

the idea is to use

ignite generator screen formschema.json => this will generate screen with form that automatically wired to backedn with realm storage

• Issue does not already exist
• Identify exactly what aspect you're issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

as noted here: facebook/react-native#2797
react native init is slow and quiet. Adding verbose lets the user know we're not just hanging.

Hi Guy'z,

I have problems using app generator.
Running ignite new MyApplication freezes on rnpm-link command.

All file seems to be there, i can run the application on ios, but i got an error on android :

Execution failed for task ':app:installDebug'.
> com.android.builder.testing.api.DeviceException: Timeout getting device list.

This error occured after updating rnpm. Before the update i was able to generate an application that runs fine on android but had a missing font error on iOS.

Any ideas ?
Thanks !

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base application
  • ignite the cli
  • ignite generated code

hi!

I'm looking forward to using ignite, but I was unable to create a new app out-of-the-box.

build command and error output

➜ ignite new MyApplication
🔥 Setting MyApplication on FIRE! 🔥
module.js:341
    throw err;
    ^

Error: Cannot find module '../validation'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.Module._load (module.js:290:25)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at Object.<anonymous> (/Users/marc/.nvm/versions/node/v5.10.0/lib/node_modules/generator-react-native-ignite/app/index.js:13:19)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)

Node ENV

➜   node -v
v5.10.0
➜   npm -v
3.8.3

• Issue does not already exist
• Identify exactly what aspect you're issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

As of right now, when you want to get your app ready to release on android, you have to do a lot of manual work. This and things like this seem to lend themselves to ignite command.

https://facebook.github.io/react-native/docs/signed-apk-android.html

• Issue does not already exist
• Identify exactly what aspect you're issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

As of right now we have some pretty decent functionality tests. But we're not testing the commands to make sure they behave as we're hoping. It would be nice to actually have fireDrill run some long-standing checks on a fresh machine to make sure we're not breaking anything as we evolve.

Developer time is too precious to re-build an entire project + apply all generators upon each verification.

HttpClient is an opinionated wrapper around fetch.

I'm going to move this to its own repo/npm module. There's more I'd like to do with and lots more tests.

Because it has usefulness outside this repo, we're going to set it free.

need to upgrade base. Notes:

Looks like there's a new compile command in iOS
facebook/react-native#7566

• Issue does not already exist
• Identify exactly what aspect you're issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base application
  • ignite the cli
  • ignite generated code

Need for the API test screen has been stubbed. Please add it.

<Navigator> is sun-setting.

<NavigatorExperimental> is transitioning in (the name will change).

I'm hearing nothing but great things about it. Redux like apparently.

Anyone up for spiking it through before its officially released? This is my only hesitation in picking a 3rd party library @ryanlntn for Navigation routing & presentation.

It's all about to change.

The PushNotification package requires the context and since the generated code does not provide it, the builds are failing.

So in MainActivity.java of the generated code, it should look like this new ReactNativePushNotificationPackage(this).

It looks like this is already fixed in the repo, maybe it's not pushed out?
https://github.com/infinitered/ignite/blob/master/ignite-base/android/app/src/main/java/com/rnbase/MainActivity.java#L42

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base application
  • ignite the cli
  • ignite generated code

Would be cool if we had a place for useful re-usable functions that each project got right away. Stub and insert a couple.

To be consistent with our Phoenix base template, I propose we rename to react_native_base. 😁

https://github.com/infinitered/phoenix_base

Make sure verify the following before submitting an issue.

• Issue does not already exist
• You have example code or some other reproduce experiment that we can verify

Consider this:
https://github.com/bcoe/nyc

generate app -> AppName ☕️ This will take a while ☕️
'wc' is not recognized as an internal or external command,
operable program or batch file.
This will walk you through creating a new React Native project in C:\Users\Dani Alvarez\AppName
Installing react-native package from npm...
events.js:141
throw er; // Unhandled 'error' event
^

Error: spawn npm ENOENT
at exports._errnoException (util.js:870:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32)
at onErrorNT (internal/child_process.js:344:16)
at nextTickCallbackWith2Args (node.js:442:9)
at process._tickCallback (node.js:356:17)
at Function.Module.runMain (module.js:443:11)
at startup (node.js:139:18)
at node.js:968:3
Too many arguments.

usage: git clone [options] [--] [

-v, --verbose         be more verbose
-q, --quiet           be more quiet
--progress            force progress reporting
-n, --no-checkout     don't create a checkout
--bare                create a bare repository
--mirror              create a mirror repository (implies bare)
-l, --local           to clone from a local repository
--no-hardlinks        don't use local hardlinks, always copy
-s, --shared          setup as shared repository
--recursive           initialize submodules in the clone
--recurse-submodules  initialize submodules in the clone
--template <template-directory>
                      directory from which templates will be used
--reference <repo>    reference repository
-o, --origin <name>   use <name> instead of 'origin' to track upstream
-b, --branch <branch>
                      checkout <branch> instead of the remote's HEAD
-u, --upload-pack <path>
                      path to git-upload-pack on the remote
--depth <depth>       create a shallow clone of that depth
--single-branch       clone only one branch, HEAD or --branch
--separate-git-dir <gitdir>
                      separate git dir from working tree
-c, --config <key=value>
                      set config inside the new repository

events.js:141
throw er; // Unhandled 'error' event
^
AssertionError: Trying to copy from a source that does not exist: C:\Users\Dani Alvarez\AppData\Roaming\npm\node_modules\generator-react-native-ignite\app\templates\ignite-base\README.md.template
at EditionInterface.exports._copySingle (C:\Users\Dani Alvarez\AppData\Roaming\npm\node_modules\generator-react-native-ignite\node_modules\mem-fs-editor\lib\actions\copy.js:45:3)
at EditionInterface.exports.copy (C:\Users\Dani Alvarez\AppData\Roaming\npm\node_modules\generator-react-native-ignite\node_modules\mem-fs-editor\lib\actions\copy.js:23:17)
at EditionInterface.module.exports [as copyTpl](C:UsersDani AlvarezAppDataRoamingnpmnode_modulesgenerator-react-native-ignitenode_modulesmem-fs-editorlibactionscopy-tpl.js:12:8)
at copyOverBase (C:\Users\Dani Alvarez\AppData\Roaming\npm\node_modules\generator-react-native-ignite\app\index.js:36:14)
at AppGenerator.generateApp (C:\Users\Dani Alvarez\AppData\Roaming\npm\node_modules\generator-react-native-ignite\app\index.js:92:7)
at C:\Users\Dani Alvarez\AppData\Roaming\npm\node_modules\generator-react-native-ignite\node_modules\yeoman-generator\lib\base.js:430:16
at processImmediate as _immediateCallback

we have fixtures, but no example of them.

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

As of right now, we enforce the install of yo, but I'd like to take a second step and be able to enforce and update of the generator. Since the generator has to be global, we can't force it properly as a dependency in package.json. Solution is to check the version and auto-upgrade. This will allow people to simply update the cli and get updated generator code, instead of updating both in global space.

Make sure verify the following before submitting an issue.

• Issue does not already exist
• You have example code or some other reproduce experiment that we can verify

Make sure verify the following before submitting an issue.

• Issue does not already exist

Add common module https://github.com/oblador/react-native-lightbox

Let's patch these two bad boys up. A fresh ignite app doesn't pass our own linting. :)

./App/Containers/AllComponentsScreen.js
  15:8  error  'I18n' is defined but never used  no-unused-vars

./App/Navigation/NavigationBar.js
  8:2  error  More than 1 blank line not allowed  no-multiple-empty-lines

It'd be nice to have a screenshot of what we're building here. Just for context.

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

Should we put a map screen inside base? Basic maps are easy, but cross platform maps with callouts and a sort of agreed upon best interaction UX, would be nice.

For those of you who've done RN maps, I would like opinions.

For those of you who have not, I'd like your gut reaction.

• Issue does not already exist
• Identify exactly what aspect you're issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

createStore will not let the enhancement parameter be null as indicated in our options:
https://github.com/infinitered/ignite/blob/master/ignite-base/App/Store/Store.js#L29

We'll either need to run a separate fewer arity createStore or figure out a benign function we can pass to this parameter.

cc: @markrickert

ignite cli does not seems to work

Get the below error on
$ node -v
v4.2.2
$ npm -v
3.5.3
$npm -g list --depth=0
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

$ ignite new react-native-aics
🔥 Setting react-native-aics on FIRE! 🔥
generate app -> react-native-aics ☕️ This will take a while ☕️
events.js:141
throw er; // Unhandled 'error' event
^

ReferenceError: colors is not defined

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

• Issue does not already exist
• Identify exactly what aspect your issue is about
  • ignite base applicattion
  • ignite the cli
  • ignite generated code

We should add fixtures for our example API, along with a test that verifies the functions available on APIFixtures at least match the functions designated on API live. This helps stop a situation where someone renames or utilizes one and not the other. Result: a large time delay between the dev who worked on a project and maybe even had their PR accepted, and the network error they would cause.

This test is valuable in generated projects.

I'd like to see @fvonhoven implement this. Thoughts welcome @skellock