Code Monkey home page Code Monkey logo

Comments (4)

alicederyn avatar alicederyn commented on May 27, 2024

Appears to occur only in Eclipse.

from freebuilder.

alicederyn avatar alicederyn commented on May 27, 2024

Specifically, to reproduce, you need Eclipse to be running its incremental compiler (e.g. by touching the Foo file above). A clean build in a standard (non-Google) Eclipse configuration will not trigger the error.

It turns out Eclipse's incremental compiler only discovers RetentionLevel.CLASS annotations on other classes, while @Freebuilder was marked RetentionLevel.SOURCE (because that's all that's strictly required). As a workaround until #11 is fixed (which will have the side-effect of solving this issue), we can use RetentionLevel.CLASS.

from freebuilder.

alicederyn avatar alicederyn commented on May 27, 2024

Reopening this. Eclipse is validly giving us only JAR-level information, albeit in a surprising situation. The actual bug is that we only check the methods declared on the user's Builder type to determine whether it provides the methods we need (clear, etc.), while @Freebuilder methods are, of course, declared on the superclass.

from freebuilder.

alicederyn avatar alicederyn commented on May 27, 2024

Reverted workaround because:

  • otherwise our claim that "you can always walk away with the code @Freebuilder generated" is no longer true
  • it's a hassle to change the @Freebuilder annotation in the Google codebase, and I'm too lazy to do it twice

from freebuilder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.