Comments (2)
Or generate addToDescendants(String element)
Easier to realize and conceptually correct.
from freebuilder.
I considered this when first creating FreeBuilder, but decided against it for a few reasons, which in no particular order are:
- We could stop generating
addDescendants(descendant)
without breaking any existing code, because we generate a varargs method with matching signature. Thus, this method can be thought of as just an optimization for the common case of adding a single element. - Typing
addDe
no longer uniquely identifies a single method name, making it more annoying to autocomplete. Some singular/plural changes are especially annoying for this, as they aren't just adding an "s" to the end. - Google Protobuf (the inspiration for the project in many ways I'm deeply indebted to) doesn't have this feature, and nobody seemed to care
- I am very much not an expert in this field. Chances were really good I'd trip over landmines regarding i18n that didn't occur to me, and if I tried to maintain the plural/singular list myself, I would likely be doing nothing but updating it. I had no examples to copy for adding extensions to annotation processors, and wanted to focus on other features.
With that said, I have no objection to someone else writing hooks into FreeBuilder that would allow them to provide a third-party depluralization service that users can opt into somehow if 2 is not a concern for them.
from freebuilder.
Related Issues (20)
- Unchecked warnings in code generated for GWT-serializable generic types
- Evaluate optimizability of internal EnumSet HOT 1
- deserializing mongodb document HOT 1
- Specify property name in exception message on nested type build failure HOT 2
- Support remaining Guava collections HOT 4
- IgnoredByEquals doesn't work HOT 6
- Alternative name for build method HOT 9
- IntelliJ, Auto-Discover Processors from Maven HOT 1
- Nested buildable types should use the enclosing type's defaults
- jackson serializer error HOT 2
- Support derived fields HOT 4
- Enhancement: Add nested builder functions HOT 2
- mergeFrom should support partials
- Support for @JsonAlias
- Not able to build on jdk 20
- Custom getters inside builder HOT 5
- JPMS HOT 10
- Java 21 throws warning with idiomatic Freebuilder usage HOT 5
- How can I install in vscode freebuilder ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freebuilder.