Comments (3)
I think the auto-flattening is just fine. See
>> import pymbolic.primitives as p
>>> a = p.Variable("a")
>>> b = p.Variable("b")
>>> c = p.Variable("c")
>>> (a * b) * c
Product((Variable('a'), Variable('b'), Variable('c'))) # flattening was legal and hence was done
>>> a * (b * c)
Product((Variable('a'), Product((Variable('b'), Variable('c'))))) # flattening wouldn't be legal and was avoided.
from pymbolic.
12569d5 removed the flattening in IdentityMapper
.
from pymbolic.
As for flatten-upon-creation, we should document that the intended eval order is from left to right, so that the flattening behavior on operator overload is fine, as @kaushikcfd states.
from pymbolic.
Related Issues (20)
- Cached mappers can't handle lists HOT 8
- Minimum python version for running tests is unexpectedly 3.10 HOT 2
- Test missing assertions HOT 3
- Pymbolic to SymEngine conversion error when using FloorDiv. HOT 6
- ParseError when parsing assignment expression HOT 4
- pymbolic interoperabiity with python ast described in the pymbolic documentation raises an exception under python 3.8.2 HOT 2
- Symengine version mismatch in CI HOT 9
- TypeError for foreign unhashable types HOT 4
- Mapper for deriving subexpressions as a list HOT 1
- [parser] Cannot parse boolean literals HOT 2
- Use a better parser HOT 3
- Applicability for Image Domain Delayed Operation Problem HOT 3
- Method for removing the `__getinitargs__` and `init_arg_names` boilerplate. HOT 1
- Symengine conversion fails due to potentially spurious isinstance check HOT 2
- [Parser] Incorrect if-else precedence
- StringifyMapper: Incorrect result for side-by-side product nodes HOT 7
- Equality comparison of DAGs can have exponential complexity
- EvaluationMapper can't handle math functions HOT 1
- Memoizing results of traversals HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymbolic.