The following test doesn't seem to be making any assertions about expected behavior:</

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Test missing assertions about pymbolic HOT 3 OPEN

inducer commented on May 25, 2024

Test missing assertions

from pymbolic.

Comments (3)

inducer commented on May 25, 2024 1

Thanks for reporting these. Contributions to address these would be very welcome.

from pymbolic.

iandinwoodie commented on May 25, 2024

Similarly, the following test seems to log a response but not make any assertions about it:

pymbolic/test/test_pymbolic.py

Lines 372 to 385 in 13e83df

    
           # {{{ test_graphviz 
        
           def test_graphviz(): 
        
               from pymbolic import parse 
        
               expr = parse("(2*a[1]*b[1]+2*a[0]*b[0])*(hankel_1(-1,sqrt(a[1]**2+a[0]**2)*k) " 
        
                       "-hankel_1(1,sqrt(a[1]**2+a[0]**2)*k))*k /(4*sqrt(a[1]**2+a[0]**2)) " 
        
                       "+hankel_1(0,sqrt(a[1]**2+a[0]**2)*k)") 
        
               from pymbolic.mapper.graphviz import GraphvizMapper 
        
               gvm = GraphvizMapper() 
        
               gvm(expr) 
        
               logger.info("%s", gvm.get_dot_code()) 
        
           # }}}

from pymbolic.

iandinwoodie commented on May 25, 2024

@inducer will do!

from pymbolic.

Test missing assertions about pymbolic HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# {{{ test_graphviz

	def test_graphviz():
	from pymbolic import parse
	expr = parse("(2a[1]b[1]+2a[0]b[0])(hankel_1(-1,sqrt(a[1]2+a[0]2)k) "
	"-hankel_1(1,sqrt(a[1]2+a[0]2)k))k /(4sqrt(a[1]2+a[0]*2)) "
	"+hankel_1(0,sqrt(a[1]2+a[0]2)*k)")

	from pymbolic.mapper.graphviz import GraphvizMapper
	gvm = GraphvizMapper()
	gvm(expr)
	logger.info("%s", gvm.get_dot_code())

	# }}}