Comments (13)
As you can see here: https://github.com/loculus-project/loculus/actions/runs/10779022293/job/29891619759?pr=2732#step:6:12 the problem is with astro-eslint-parser
.
from eslint-plugin-import.
Thanks! Strangely I can't reproduce actually after a fresh checkout and npm ci
.
from eslint-plugin-import.
Yep, that one's still bumped here and it doesn't error (in that place): https://github.com/loculus-project/loculus/actions/runs/10781731886/job/29900275170?pr=2739
from eslint-plugin-import.
2.8.1, see screenshot above
from eslint-plugin-import.
cc @michaelfaith it'd be great to get a fix for this in its own PR/commit (i think you may already be looking at it for #2996)
from eslint-plugin-import.
Do you have a repo that can easily reproduce this, or steps to reproduce it in this repo's examples? That'll help with testing and validation.
Also maybe it is the mjs
/ cjs
addition after all? I wouldn't have thought that'd have caused such a thing, but I notice the path in the parsing error has an mjs
extension. Is the astrolint-eslint-parser
able to parse esm files?
Either way, if I can reliably reproduce it, I'll work on putting a fix up.
from eslint-plugin-import.
Wait, I can reproduce it again. The eslint cache might have thrown me.
The error does get triggered by the upgrade to 2.30.0. It might well be that the astro-eslint-parser contributes but some code change in eslint-plug-import
makes it happen only now.
from eslint-plugin-import.
and you're sure it's not from updating @typescript-eslint/parser
? (the astro parser wraps that)
from eslint-plugin-import.
Does it happen with v2.29.1 of the import plugin and v2.10.0 of eslint-module-utils?
from eslint-plugin-import.
Nope, doesn't happen in that case, that diff doesn't trigger it either:
Yes indeed, I can trigger it just by updating:
npm i [email protected]
from eslint-plugin-import.
What version did you have previously? 1079e70 is the only change in v2.10.0 that's not in v2.9.0, and that doesn't seem like it could be relevant. 806e3c2 was added in v2.9.0, but that only added .mjs
and .cjs
as valid default extensions.
from eslint-plugin-import.
ah, thanks :-) could you try v2.8.2 and v2.9.0, just to be sure?
from eslint-plugin-import.
Indeed it is the upgrade from 2.8.2 -> 2.9.0
❌1 ❯ npm i [email protected]
changed 1 package, and audited 1181 packages in 2s
390 packages are looking for funding
run `npm fund` for details
6 high severity vulnerabilities
To address all issues (including breaking changes), run:
npm audit fix --force
Run `npm audit` for details.
loculus/website on dependabot/npm_and_yarn/website/minorandpatch-b0e14b6152 [$!?] is 📦 v0.0.1 via v22.8.0 in ☸ aws (default) on ☁️ (us-east-1)
❯ npm exec eslint /Users/corneliusromer/code/loculus/website/src/layouts/BaseLayout.astro
=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0
YOUR TYPESCRIPT VERSION: 5.6.2
Please only submit bug reports when using the officially supported version.
=============
loculus/website on dependabot/npm_and_yarn/website/minorandpatch-b0e14b6152 [$!?] is 📦 v0.0.1 via v22.8.0 in ☸ aws (default) on ☁️ (us-east-1) took 6s
❯ npm i [email protected]
changed 1 package, and audited 1181 packages in 970ms
390 packages are looking for funding
run `npm fund` for details
6 high severity vulnerabilities
To address all issues (including breaking changes), run:
npm audit fix --force
Run `npm audit` for details.
loculus/website on dependabot/npm_and_yarn/website/minorandpatch-b0e14b6152 [$!?] is 📦 v0.0.1 via v22.8.0 in ☸ aws (default) on ☁️ (us-east-1)
❯ npm exec eslint /Users/corneliusromer/code/loculus/website/src/layouts/BaseLayout.astro
=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0
YOUR TYPESCRIPT VERSION: 5.6.2
Please only submit bug reports when using the officially supported version.
=============
Error while parsing /Users/corneliusromer/code/loculus/website/node_modules/react-toastify/dist/react-toastify.esm.mjs
Line 4, column 0: Unknown token at 15458, expected: "}", actual: ""
`parseForESLint` from parser `/Users/corneliusromer/code/loculus/website/node_modules/astro-eslint-parser/lib/index.js` is invalid and will just be ignored
/Users/corneliusromer/code/loculus/website/src/layouts/BaseLayout.astro
3:32 error Parse errors in imported module 'react-toastify': parser.parse is not a function (undefined:undefined) import/no-deprecated
✖ 1 problem (1 error, 0 warnings)
from eslint-plugin-import.
Related Issues (20)
- This plugin does not report `import/extensions` and `import/no-unresolved` errors on `import type …` constructs HOT 3
- Making `ExportMap` available in `eslint-module-utils`?
- Update `tsconfig-paths` dependency to v4 HOT 1
- Regression in import/order rule after v2.26 HOT 1
- Mixed `type` imports does not trigger `import/no-duplicates` HOT 1
- Config to match vscode import sorting default HOT 2
- corrupted dependencies on windows?
- How to make it recognise internal modules as not external?
- Support for eslint v9 alternative HOT 1
- `import/consistent-type-specifier-style` for exports HOT 1
- Even larger `import/no-cycle` performance downgrade in 2.30.0 HOT 9
- eslint(import/named) reports `not found` errors in 2.30.0 HOT 7
- Enhancement: [import/no-restricted-paths] accept target exceptions HOT 5
- Missing documentation on how to setup eslint-plugin-import with flat confiuration and Typescript HOT 13
- eslint > 9 as peer dependency of eslint HOT 3
- Rule to detect import of modules with and without directives HOT 3
- import/no-named-as-default-member rule became less useful in 2.30.0 HOT 1
- Missing `^9` eslint peer dependency HOT 2
- 🐞: [import/newline-after-import] Cannot recoginize the last require when use import and require in the same file HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-import.