Even larger `import/no-cycle` performance downgrade in 2.30.0 about eslint-plugin-import HOT 9 OPEN

@ljharb yep, it does

from eslint-plugin-import.

What happens if you set the disableScc option to true? Does it restore the v2.29 speed?

cc @soryy708

from eslint-plugin-import.

IMO it's a good heuristic because:

• If your project is small, lint takes seconds, so you don't care about performance as much, don't mind the overhead
• If your project is large, lint takes minutes, so you care about performance, and want more efficiency

Defaults that cater to large codebases (perhaps at the expense of tiny ones) are good, while there is an escape hatch in case the user cares enough.

from eslint-plugin-import.

Same for me: it is worse now. Went from

Rule                                 | Time (ms) | Relative
:------------------------------------|----------:|--------:
import/no-cycle                      |  5091.198 |    31.2%

to

Rule                                 | Time (ms) | Relative
:------------------------------------|----------:|--------:
import/no-cycle                      |  6829.761 |    39.1%

from eslint-plugin-import.

Cool, glad we decided to put disableScc in.

The SCC is a pre-processing we do to speed up no-cycle to enable early-exit (short-circuiting). In large projects with many files to lint, it prunes a lot of unnecessary work, but in small projects the preprocessing can take longer than the time it saves.

from eslint-plugin-import.

Is there any way we could figure out a heuristic, and dynamically figure out whether it’ll be faster to use scc or not?

from eslint-plugin-import.

Is there any way we could figure out a heuristic, and dynamically figure out whether it’ll be faster to use scc or not?

I don't have anything in mind. It depends on a lot of things - the user's hardware, cpu, how fast their hdd/ssd is...

If the heuristic will be right then great, the user won't need to configure anything.

But what if the heuristic will be wrong? They'll need to override the heuristic's decision, either to enable or to disable SCC.

from eslint-plugin-import.

That’s already the case - we just chose a heuristic of “always use scc”. The hope would be do minimize how many users have to enable or disable scc explicitly.

from eslint-plugin-import.

I totally agree that it's the right heuristic :-) i'm just wondering if we can fine-tune it a bit for projects in the 20-70s range.

from eslint-plugin-import.