immoweltgroup / create-react-microservice Goto Github PK

Describe the problem:

Since the concept of a PWA is getting more and more grip these days, we should definitely add a recipe on how to add offline-first support to the scaffold

Describe the problem:

create-react-microservice strips numeric values from npm orgs, which are actually legal in org names.

Steps to reproduce:

1. Run create-react-microservice my-project
2. Set an org name with some numeric values (e.g. test39)

Observed Results:

• What happened? This could be a description, log output, etc.

The org scope will be set to @test/

Expected Results:

• What did you expect to happen?

Numeric values should be preserved, so the org scope should be set to @test39/

To smoothen the creation of issues / pull requests

Maybe we can also look into automatically creating a bundle for each and providing the same functionality in that regard to multi-route code-splitting and server side rendering.

Describe the problem:

In case you developed the scaffold further, cleaned it afterwards and executed the integration tests. The scaffold creation will fail with an EOENT error that the .editorconfig or .prettierrc does not exist.

Describe the problem:

Running create-react-microservice with @ notated org, appends instantly a second @, for example in cli configuration on creating react microservice we use @tesorg after hitting enter the cli appends a second @ to the name @@testorg/. This cause in the yarn install process a error package.json: Name contains illegal characters

Steps to reproduce:

create-react-microservice my-fancy-ui
What is the preffered license for the mono repository and its packages? MIT
What is the NPM organization scope for the mono repositories packages? @testorg

Observed Results:

create-react-microservice » Error: Command failed: yarn install
error package.json: Name contains illegal characters

A module like https://github.com/sindresorhus/latest-version could be used to query the latest CLI version, and if it differs the user could be prompted to update.

Describe the problem:

Currently the create-react-microservice does not support the --help flag. Since this is common for most CLIs and users expect a way to see all options/flags the CLI exposes, we should integrate it as soon as possible.

It would be nice if all mono-repo packages automatically get the git repository URL written into the package.json. We could make this question optional and if it was provided install husky / linted-staged, and if not remove the .lintstagedrc file from the root of the repo.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Location: renovate.json
Error type: The renovate configuration file contains some invalid settings
Message: Invalid configuration option: docker

Currently the i18n setup is pretty static, which means that it is not possible to switch the language at runtime, this should be implemented since there might be cases where even a frontend microservice changes the language at runtime

Maybe it is also worth a look switching to https://github.com/florian/x18n

...

.... as the title suggests ...

Describe the problem:

The published artifact of the components package misses the .babelrc, .eslintrc and most importantly the package.json.

Steps to reproduce:

1. Simply try to create a new service with the service based on the releases published on NPM.

It would be nice if we could enhance the code splitting into one module for the store, and one for the current route. That way we can get more out of HTTP/2's multi-plexing.

Before we publish 1.0.0 we should integrate semantic release for a smoother release cycle.

Describe the problem:

create-react-microservice failing on windows

Steps to reproduce:

Run create-react-microservice to create a mono-repo on a Windows machine

Observed Results:

• What happened? This could be a description, log output, etc.

create-react-microservice test-ui-microservice
? What is the preffered license for the mono repository and its packages? (Use a
rrow keys)
> Unlicense
? What is the preffered license for the mono repository and its packages? MIT
? What is the NPM organization scope for the mono repositories packages? @TFG
? What is the NPM organization scope for the mono repositories packages? @tfg/
? What is the git repository URL for the mono repositories packages? https://github.com/ERS-HCL/react-microservice.git
? What is the git repository URL for the mono repositories packages? https://git
hub.com/ERS-HCL/react-microservice.git
{ Error: E:\workspace\test-ui-microservice\E:\Users\tsukhu\AppData\Local\Yarn\Data\global\node_modules\create-react-microservice-scaffold\src\__tests__ contains invalid WIN32 path characters.
    at Object.mkdirs (E:\Users\tsukhu\AppData\Local\Yarn\Data\global\node_modules\fs-extra\lib\mkdirs\mkdirs.js:18:22)
    at Object.mkdirs (E:\Users\tsukhu\AppData\Local\Yarn\Data\global\node_modules\universalify\index.js:5:67)
    at pathExists (E:\Users\tsukhu\AppData\Local\Yarn\Data\global\node_modules\fs-extra\lib\output\index.js:20:11)
    at fn.apply.then.r (E:\Users\tsukhu\AppData\Local\Yarn\Data\global\node_modules\universalify\index.js:23:46)
    at <anonymous> code: 'EINVAL' }

We should switch to HTTPS by default, maybe by integrating LetsEncrypt / auto-sni or at least a dummy certificate for development.

Describe the problem:

As of now the scaffold does not provide flow support for the jest spec files of reselect selectors. The reason why we haven't added it in the first place was that the selector is typed with the global StateType of the application, and the tests only provide a subset of it since it would otherwise increase the maintainability of the tests into nowhere.

A possible solution would be to either add a } | Object to the global StateType declaration, but this solution would also lead to less feedback from flow in the real world usage.

Describe the problem:

Currently the example feature development docs do not fully reflect the best practices in regards to tests.

As soon as a user installs a new dependency inside a mono-repo package, yarn will remove the symlinks created by the flow-mono-cli. It would be super helpfull if they would be re-created until yarn#4219 is solved.

Describe the problem:

When creating a new redux-module via yarn run create in the root of the mono-repo, it would be nice to not having the manual register process of the module outsourced to the user.

Instead we should think about having some kind of process with e.g. babel to automatically register it

https://github.com/ImmoweltGroup/create-react-microservice/blob/master/packages/create-react-microservice-scaffold/src/build/templates/redux-module/create-config.js#L22-L34

Describe the problem:

After a release was triggered via CI, the git tags are not properly named, e.g. for version v1.0.4 the git tag name is v0.0.0-development, e.g. https://github.com/ImmoweltGroup/create-react-microservice/releases/tag/v0.0.0-development

Describe the problem:

Since we've already got the create-any-cli tool setup in the root of the scaffold, it would be nice to have templates to scaffold new node or browser related packages.

We should also make sure to document the workflow with the create CLI.