imabug / raddb Goto Github PK

Add buttons to allow modification of machine and/or tube information

On the main index page, the previous and current survey IDs need to be linked to their respective recommendations page.

Adding a new survey produces this error

QueryException in Connection.php line 769:
SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (raddb.testdates, CONSTRAINT testdates_tester2_id_foreign FOREIGN KEY (tester2_id) REFERENCES testers (id)) (SQL: insert into testdates (test_date, machine_id, tester1_id, type_id, accession, updated_at, created_at) values (2017-1-1, 11, 2, 1, 4454545, 2016-12-09 10:58:55, 2016-12-09 10:58:55))

URL for adding a new operational note from the machine detail page isn't being generated properly.
http://localhost:8000/opnotes/create?288 is being created, but should be getting something like http://localhost:8000/opnotes/288/create instead.

Deleting an x-ray tube from the machine detail page returns a blank page

Confirmation message shown when just adding a new survey recommendation is "Service report uploaded"

Should change that.

Status indicator is missing from the machine detail page.

Should also have some indication that a machine is inactive/removed.

Get a list of survey IDs that don't already have uploaded survey reports to use in the survey report upload form

Survey schedule section on the main index page doesn't show machines with multiple surveys in the current year properly. Probably related to the way the query results are obtained.

ReflectionException in RouteSignatureParameters.php line 25:
Class RadDB\Http\Controllers\StoreSurveyReport does not exist

error produced when uploading a service report

Op notes listing page only shows part of the form for adding a new operational note. Machine selector is missing.

Show some kind of confirmation of successful report upload

Using route names should make things a little more flexible

https://laravel.com/docs/5.3/routing#named-routes

Show some kind of confirmation dialog when a new machine has been successfully added to the database

The notes must be a string. error produced when adding a new survey with empty notes field.
Shouldn't be a required field for submitting the form

Move the location and modality listings into their respective controllers. Makes more sense to have them there than in MachineController

The machine listing by location index page should show the location in the header of each group

Need to be able to add/edit operation notes

Add photo uploads for machines to display on the machine detail page.

The rec resolve date does not match the format Y-m-d.
The resolved by must be a string.

validation errors were produced when adding a new survey recommendation. These should not be checked for unless the resolved checkbox is set.

See https://github.com/imabug/raddb_laravel/issues for some of the old issues

Changing machine status on machine edit page fails to set the status

Create database seeders to fill DB with test data

Need to create some user documentation/help files

Pages to track equipment calibrations would be useful.

Create separate pages for each section of the index page. Make them accessible from the Dashboard menu

ErrorException in RecommendationController.php line 179: Creating default object from empty value in RecommendationController.php line 179 at HandleExceptions->handleError('2', 'Creating default object from empty value', '/opt/www/raddb/app/Http/Controllers/RecommendationController.php', '179', array('request' => object(Request), 'surveyID' => '2016', 'resolved' => array('3187'), 'recResolveDate' => '2017-01-11', 'serviceReportPath' => 'public/ServiceReports/22b0fda0a1cc4d42bf4187706692b145.pdf', 'recommendation' => object(stdClass))) in RecommendationController.php line 179

Machines that don't have a survey in the previous year are missing from the survey schedule listing on the index page.

Need to adjust the $surveySchedule query to try to grab these machines

Show some kind of confirmation dialog when a new tube has been successfully added to the database

Need to keep unauthorized users from deleting or modifying things

When resolving multiple recommendations in the same form submission, a submitted service report ends up getting saved multiple times.

Machine status is always set to Active when editing machine information. Status should be set to whatever is stored in the database.

The machine list by modality index page should show the modality in the heading for each group

Add application testing

Handle application errors more gracefully

Show some kind of confirmation dialog when a new survey is added

ErrorException in TubeController.php line 135:
Undefined variable: tube

error produced when trying to edit tube from the machine detail page

URLs all start at the root directory of the web server. Should make them relative

Need to check for existing file and either have the user confirm up load or reject the upload request.

Dashboard pages should have a link to survey recommendations

Resolving a single recommendation from recommendation listing page results in an error

ErrorException in RecommendationController.php line 184:
Invalid argument supplied for foreach()

Work order number field apparently can't be left empty when resolving recommendations from the recommendation listing page.

Split survey and service report handling into their own controllers. Should make for easier maintenance.

Variable naming is somewhat inconsistent across PHP and HTML files leading to errors like what caused #76

Should either use variable names with _ or camelCase for variable names in all files.

Should have user roles such as admin to separate user functions

Machine edit form is not updating the manufacture and install date fields