When I ran the sync from Moodle's scheduled task, I will get these 'notice' messages (multiple ones), but no such 'notice' on second run.

Enrolling instructors to Course ID 2754 with Role ID 11 through Ilios Sync ID 16222.


Notice:  Trying to get property of non-object in /var/www/html/enrol/ilios/locallib.php on line 135

  enrolling with 0 status: userid 21004 ==> courseid 2754

ensure that this enrolment plugin compatible with Moodle 4.

solution: override can_delete_instance() method.

see https://github.com/moodle/moodle/blob/MOODLE_32_STABLE/lib/enrollib.php#L1957

override this method.

From Valentina,

One thing I noticed however, is that it is not possible to update or correct a sync that has already been created.

For instance, if I find out that I mistakenly am syncing the wrong learner group from Ilios, I cannot simply update it; the fields I want to change are not editable. To fix it, I must delete that sync method entirely and recreate another one.

Can this be fixed?

When enrol_ilios_plugin::sync() is evoked by Moodle scheduled task, it calls the global function enrol_ilios_sync(), which will create another instance of enrol_ilios_plugin, which again has its own copy of ilios_client. This second instance of ilios_client is running fine, and renewing the API key all that. And when the second instance of enrol_ilios_plugin is done and calls its destructor, it is saving the new API key correctly. Unfortunately, when the outer (first) instance of enrol_ilios_plugin is being destroyed, its destructor will override the new API key with the old one that comes from its own copy of ilios_client.

I would just get rid of the file locallib.php and the global function enrol_ilios_sync(). Then move the logics in enrol_ilios_sync() into enrol_ilios_plugin::sync().

please add some basic instructions (including installing dependencies) to the README file (see #1).
thanks!

so that i can be re-used.
put the client into a locallib plugin and make this enrolment plugin depend on it.

Provide a way to create multiple Ilios Sync instances with selected Ilios groups at the same time.

With SIS enrollment, if a student's enrollment is inactivated on the SIS side, then the enrollment in the corresponding Moodle could is automatically suspended. This is a good thing.

This doesn't currently occur with the Ilios sync enrollment plugin.

There have been a few instances in the past (one just a couple weeks ago), where an SOM or SOP student has withdrawn from UCSF. And the ed/tech folks in these schools have asked that we suspend the student's Moodle account ASAP so they can't access course materials, since any deactivation that takes place on the Ilios side doesn't change the enrollment status on Moodle.

Addendum 9/24/19
Per CLE team discussion, the scope should be expanded to allow for three options on how to deal with existing enrollments for suspended ilios users in moodle.

1. suspend enrollment
2. unenroll
3. do nothing (default)

Add the necessary options to the enrollment instance configuration form.

Addendum 10/16/19

no additional config needed. instead, suspend active enrollments of disabled Ilios user accounts.

In this line of code, https://github.com/ilios/moodle-enrol-ilios/blob/master/lib.php#L295, when $group->users is an empty array, getbyids() will return a random list of users.

This is related to ilios/local_iliosapiclient#9

From Valentina:

I am trying to confirm that I have correctly implemented the sync on the forum page.

When I go to any of the entries that I used the Ilios à CLE tool for, I cannot see the listing of the sub-group. This is a big problem, because it means that there is no way for me to check my work.

I did set them up to bring in sub groups from Ilios and I believe it is still doing that since it shows me that there are only 17 users enrolled.

However, I need to verify that I have associated the right sub-groups and they don’t show up on the interface.

Seeing this error in the Moodle cron output:

[410688] Scheduled task failed: Ilios enrolment sync (enrol_ilios\task\ilios_sync_task),Attempt to assign property "instructors" on null
[410688] Backtrace:
[410688] * line 275 of /enrol/ilios/lib.php: call to enrol_ilios_plugin->getGroupData()
[410688] * line 57 of /enrol/ilios/classes/task/ilios_sync_task.php: call to enrol_ilios_plugin->sync()
[410688] * line 259 of /lib/cronlib.php: call to enrol_ilios\task\ilios_sync_task->execute()
[410688] * line 120 of /lib/cronlib.php: call to cron_run_inner_scheduled_task()
[410688] * line 73 of /lib/cronlib.php: call to cron_run_scheduled_tasks()
[410688] * line 178 of /admin/cli/cron.php: call to cron_run()
[410688]

to provider better exposure to Ilios prospects.

After I deleted an Ilios Sync instance in a course, I could still find those users with role assigned under 'Other users'. They do not show up under 'Enrolled users' list, though, which is correct.

Technical note: These users need to be removed from both user_enrolments and role_assignments tables, depending on Unenrolaction value.