iler / alpine-nginx-pagespeed Goto Github PK

In your Dockerfile:

• Single ENV block to limit the number of layers like ENV foo=123 bar=456 (can be on multiple lines with \).
• Install ca-certificates instead of using --no-check-certificate
• Do apk add --no-cache -t .build-deps package1 package2 && ... && apk del .build-deps cleaner than runtime_pkgs
• set -x at the beginning of the long command to see each command in when building.
• Indent multiline commands

Hello, looking at this dockerfile and trying to figure out what the patches are used for?
Something appears to result in No threading detected and i'm trying to understand if this is a limitation in any way or not? And also if these patches are required / suggested as best practices or is it something very specific to your own use-case ?

thank you.

/etc/nginx # nginx -t
2016/04/30 20:17:24 [info] 20#0: [ngx_pagespeed 1.10.33.7-0] No threading detected. Own threads: 1 Rewrite, 1 Expensive Rewrite.
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx: configuration file /etc/nginx/nginx.conf test is successful

/etc/nginx # nginx -V
nginx version: nginx/1.9.15
built by gcc 5.3.0 (Alpine 5.3.0)
built with OpenSSL 1.0.2g  1 Mar 2016
TLS SNI support enabled
configure arguments: --with-ipv6 --prefix=/var/lib/nginx --sbin-path=/usr/sbin --modules-path=/usr/lib/nginx --with-http_ssl_module --with-http_gzip_static_module --with-file-aio --with-http_v2_module --without-http_autoindex_module --without-http_browser_module --without-http_geo_module --without-http_map_module --without-http_memcached_module --without-http_userid_module --without-mail_pop3_module --without-mail_imap_module --without-mail_smtp_module --without-http_split_clients_module --without-http_uwsgi_module --without-http_scgi_module --without-http_referer_module --without-http_upstream_ip_hash_module --prefix=/etc/nginx --conf-path=/etc/nginx/nginx.conf --http-log-path=/var/log/nginx/access.log --error-log-path=/var/log/nginx/error.log --pid-path=/var/run/nginx.pid --add-module=/tmp/src/ngx_pagespeed-1.10.33.7-beta --with-cc-opt='-fPIC -I /usr/include/apr-1' --with-ld-opt='-luuid -lapr-1 -laprutil-1 -licudata -licuuc -L/tmp/src/modpagespeed-1.10.33.7/usr/lib -lpng12 -lturbojpeg -ljpeg'

Just like official Nginx on Alpine, I'd redirect to stdout:

RUN
  # forward request and error logs to docker log collector
 && ln -sf /dev/stdout /var/log/nginx/access.log \
 && ln -sf /dev/stderr /var/log/nginx/error.log

I would like to submit a build patch for a Drupall application specific nginx instance, but I think that you probably don't want it merged into this image. Will you create child images for various purposes?

• php-fpm application?
• backend proxy?
• multi-backend proxy?

If so, then it makes sense for me to wait to submit patches there. I may open a pull request, only to demo that php-fpm application requirements.

Thanks for sharing. I just noticies two issues.

1. This red message keeps repeating all the time during compilation and I don't know why.

<command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition

2. You may remove line 75 of Dockerfile (

   alpine-nginx-pagespeed/Dockerfile

   Line 75 in 715be75

   --prefix=/var/lib/nginx \

   ) as you're reseting prefix in line 96 (

   alpine-nginx-pagespeed/Dockerfile

   Line 96 in 715be75

   --prefix=/etc/nginx \

   )