ilcatania / holiday-temps Goto Github PK

current holiday retrieval goes straight to "England and Wales" holidays irrespective of the city being passed as input. It should at the very least check that the input city is indeed in England or Wales, or even better figure out where it is and load holidays accordingly.

singular/plural, packages etc

Currently test suite only has WireMock based unit tests for the two service implementations consuming external REST services, and a Mockito based unit test for the REST service implementation. A full end to end integration test is missing.

currently JSON parsing from external web services is done into plain lists/maps. This is potentially unsafe and makes code much uglier. Migrate to ad hoc data model to be serialized/deserialized via jackson.

Holiday filtering by date is not implemented, so all dates are currently returned.
This includes future dates, they should obviously be filtered out as there won't be any dates

e.g. I tried Birmingham and two woeids are being returned. At the very least a warning should be logged. Right now, the service silently takes the first returned entry.

Make sure that version is specified for dependencies in build.gradle, and migrate the CI setup to use a static ubuntu version instead of ubuntu-latest

Current unit test suite only covers one single happy flow per implementation. Should extend to cover bad input, bad output, corner cases, missing data, etc/