ikucherenko / go-java-1 Goto Github PK

No description was provided for this review request. See branch link for all 
revisions related to this review.

дописать

1) imin1 - имя переменной не в camelcase. vect и другие: 
лучше сделать чуть длиннее но осмысленней 
(см. Clean Code)
2) mass() - 
  а) название невыразительное 
  б) имена производные не от английских слов - плохая практика ;
     можно   назвать getArray(), retrievArray()
calc() и остальные по аналогии
3) пузырьковая сортировка - самая медленная 
из всех возможных ,  не нужно писать свою, 
т.к. есть сортировка из коробки
4) форматирование. отступы, пробелы около 
бинарных операторов. нужно делать по convention

1) should be extracted Domain Model classes

1) дописать логику
2) переменные переименовать по Clean Code

1) при любом входе возвращает 
java.lang.ArrayIndexOutOfBoundsException 

Branch name: 
trunk/GoJava1/aleks.poleshchuk/module1/finance/ua/com/goit/gojava/alekspole/fina
nce

Purpose of code changes on this branch:
Committing my first version of finance aggregator with two user stories:
1) Show all available finance indicators and their values for TODAY.
2) Show historical changes for a particular indicator value.

When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk

Branch name: svn/  trunk/ GoJava1/ dmytro.reydalov/ module2/ Interview 
Simulator/ src/ ua/ com/ goit/ gojava2/ solo307/ interview  

Purpose of code changes on this branch:to make an interactive menu, which will 
offer to user choose one of several options.
1)will show question and answer to it.
2)will show a question and a two answers - user will choose a one of options
and will get a message, success, or fail.

When reviewing my code changes, please focus on: metod readUserAnswer()in 
Question class i want to make it more flexible. should i make another kind of 
menu object, wich will receive an instance of answer - and will print answers - 
assigns numbers to it - and will read users choise and return it? or better 
will return true, or false...

After the review, I'll merge this branch into:
/trunk svn/  trunk/ GoJava1/ dmytro.reydalov/ module2/Archive/Interview 
Simulator 0.1/

Branch name:
/trunk/GoJava3/avelitchenko

https://code.google.com/p/go-java-1/source/browse/#svn%2Ftrunk%2FGoJava3%2Faveli
tchenko%2FBigDataMergeSort%2Fsrc%2Fua%2Fgoit%2Falg

BigDataMergeSort

Branch name:

Purpose of code changes on this branch:


When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk

Branch name: ua.com.goit.gojava.myshko.ProjectOfficeManagement

Purpose of code changes on this branch: first version, implementation of two 
first user stories

When reviewing my code changes, please focus on: - 


After the review, I'll merge this branch into: - 

Branch name:

Purpose of code changes on this branch:


When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk

RCModel Project

дописать

GoJava3/GoJava3_2/Serializing