Code Monkey home page Code Monkey logo

browser's Issues

Link from facebook share

When clicking on a shared link on facebook from iphone 6, this package is returning true for:

if( Browser::BROWSER_IE && $browser->getVersion() < 9 ) {

}

user agent is

Mozilla/5.0 (iPhone; CPU iPhone OS 8_2 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Mobile/12D508 [FBAN/FBIOS;FBAV/26.0.0.11.13;FBBV/7806348;FBDV/iPhone7,2;FBMD/iPhone;FBSN/iPhone OS;FBSV/8.2;FBSS/2; FBCR/O2;FBID/phone;FBLC/en_GB;FBOP/5]

use of $_os ?

Hello, why do you use this variable : $_os ?
you init she and, you set she to "unknow", with the function "reset", but that's all

"Unknown" iPhone or iPad version when using Chrome

When i use Chrome on my iPhone or iPad device (Tested using Browserstack). The getBrowser() returns "iPhone" but the getVersion() returns "unknown". I have to specify to following in order to pass the evaluation.

\Ikimea\Browser\Browser::BROWSER_IPHONE => 'unknown'
\Ikimea\Browser\Browser::BROWSER_IPAD => 'unknown'

Is this a known issue?

Notice when checking user agent

Notice: Undefined offset: 1 .../vendor/ikimea/browser/lib/Ikimea/Browser/Browser.php 660

User agent: Dalvik/2.1.0 (Linux; U; Android 8.0.0; ONEPLUS A3010 Build/OPR6.170623.013)

Line 660: $aversion = explode(' ', $aresult[1]);

It seems that some user agents don't have space right after OPR than the notice is logged

Version numbers as integer

It will make easy to use conditions like < 40, currently chrome versions are more something like "42.0.123.4"

Create stable tag for Composer installs

Currently everything is displayed in Packagist with dev-master but doing so doesn't allow the package to be installed with a minimum stability of stable, only dev. To fix this, create a version tag so that Browser can be installed in stable Composer installs.

Add Ubuntu as OS

Hi, it would be nice to add Ubuntu in the list of OPERATING_SYSTEM.

Currently my user agent string is:
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.