iiroj / react-sticky-nav Goto Github PK

For example, Tailwind CSS's utility class 'hidden' --> display: none
Recommend class name: 'sticky-hidden'

After updating to v4 the nav doesn't hide anymore when the position prop changes to hidden. Used the exact styles and content from the example.

Otherwise the props seem to work as expected and there aren't any extra rerenders anymore when the position prop changes. 👍

Issue occurs here

To fix this I changed it to

ref.current.style.top = `${newTop}px`;

I'm not sure whether or not to create PR because this issue doesn't seem to be affecting anyone else. It might be because typescript won't allow the implicit type conversion? Not too sure because no errors get thrown. Using styled-components, when i set the initial value for top to 0 it would always be 0px instead of plain 0, so I had to do this to get the animation to work.