ihe / iti.npfs Goto Github PK

and add to update

Section Number Identify the most specific section number the issue occurs (e.g. 4.1.2)
2:3.87.4.1.2
Issue Describe your issue. Don't write a book, but do include enough to indicate what you see as a problem.
The following link to DocumentReference includes a ')' in the link, so clicking it gives a 404

shall contain one FHIR DocumentReference Resource (https://www.hl7.org/fhir/R4/documentreference.html) with the file’s metadata.

Proposed Change Propose a resolution to your issue (e.g., suggested new wording or description of a way to address the issue). The committee might simply accept your suggested text. Even if they don't, it gives a good sense of what you are looking for. Leaving this blank means you can't imagine how to resolve the issue, which makes it easier for the committee to admit they can't imagine how to resolve it either and leave it unresolved.

Remove the trailing ')' from the link

Priority:

• Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

Can you make the references to other supplements or final text be links to those? For example, 3.87.4.1.2 has links to Appendix W, BPPC, and XDW. You can also change references to "TF-2x" to just "TF-2".

Section Number Identify the most specific section number the issue occurs (e.g. 4.1.2)
1:47.4.2.1
Issue Describe your issue. Don't write a book, but do include enough to indicate what you see as a problem.

There is some minor corruption in the first sentence:

"A technician creates a stylesheet to render the XML of CDA®[^1] Laboratory Reports produced in all the Laboratory Information System (LIS) involved in the Healthcare Information Exchange (HIE). "

It looks like the PDF referred to a footnote about CDA being a registered trademark of HL7.

Proposed Change Propose a resolution to your issue (e.g., suggested new wording or description of a way to address the issue). The committee might simply accept your suggested text. Even if they don't, it gives a good sense of what you are looking for. Leaving this blank means you can't imagine how to resolve the issue, which makes it easier for the committee to admit they can't imagine how to resolve it either and leave it unresolved.

Remove the bracketed reference or add a footnote with the trademark declaration.

Priority:

• Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

I noticed that DocumentReference.subject is set to 0..0; the .subject element may still be useful for subjects that are not patient. It seems that the subject should be restricted to not be a Patient?

Practitioner -- this is individual, so I wonder if we really want NPFS to also be (non practitioner)?

Group -- groups can be made up of Patients. So it is not clear how we would allow Group, but not allow Groups of Patients.

Device -- often a Device is associated with a Patient, although many Devices are just Devices. Allowing Device might be the most clear use-case.

All this said. I am not clear that we should allow something in subject. Seems we should have a positive use-case to drive deviation from 0..0

Note that in the future, using FHIR R5, subject can be a reference to ANY kind of Resource. This is just mentioned as foreshadowing, it should not be part of the current profile.

Should this be an open issue?

See MHD, that has defined a profile of Bundle for the purpose of ITI-65.
https://github.com/IHE/ITI.MHD/blob/master/input/fsh/provideBundle.fsh

ITI-87 should have similar profiling. This would then be referenced in place of the text on 3.87.4.1.2 that describes the Bundle.

This document begins the definition of a value set for the class element. How do we complete the value set for this profile. Suggestions are requested. How do we coordinate this value set with other Document Sharing profiles? Suggestions are requested.

I don't think there should be a preferred binding to the IHE FormatCode, or any reference to the IHE FormatCode. The reason is that these codes are all patient specific, which NPFS is not.

Remove the dependency on ihe.formatcode valueset, and do not constrain to it.

This document does not require the use of profile tags to identify compliant resources. Use of profile tags will also allow the File Consumer to search just for resources that matches this profile in a FHIR Server that store different types of resources. Readers are required to provide feedback on this topic.

I understand that CP 1139 was integrated already into the IG. Given that this was a balloted CP, we indicate the integration in the "Significant Changes" section. So please add a bullet to that section indicating the CP 1139 was integrated.

Section Number Identify the most specific section number the issue occurs (e.g. 4.1.2)
1:47.4.2.2.2
Issue Describe your issue. Don't write a book, but do include enough to indicate what you see as a problem.
The third bullet references ITI TF-2c. Now that we are moving to web we don't use the subvolume labels anymore, I think.

Proposed Change Propose a resolution to your issue (e.g., suggested new wording or description of a way to address the issue). The committee might simply accept your suggested text. Even if they don't, it gives a good sense of what you are looking for. Leaving this blank means you can't imagine how to resolve the issue, which makes it easier for the committee to admit they can't imagine how to resolve it either and leave it unresolved.

Change 2c->2.

Priority:

• Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

as part of the conversion there are some images-source and images that were created but no longer used as plantuml diagrams are now used. These unused files should be removed from the github repo.

Section Number Identify the most specific section number the issue occurs (e.g. 4.1.2)
2:3.87.4.4.2
Issue Describe your issue. Don't write a book, but do include enough to indicate what you see as a problem.
There is some strange indenting when describing the failure cases:

Proposed Change Propose a resolution to your issue (e.g., suggested new wording or description of a way to address the issue). The committee might simply accept your suggested text. Even if they don't, it gives a good sense of what you are looking for. Leaving this blank means you can't imagine how to resolve the issue, which makes it easier for the committee to admit they can't imagine how to resolve it either and leave it unresolved.

I think these do not need to be indented.

Priority:

• Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

The inline examples are hard to read as a table. Can you change these to use the code block in markdown (```)? Or if they already exist as example resources, you can just link to those in the IG and take out the figure. For example, "Figure 3.87.4.1.2.5-1: Create File Request example".

There are many NPFS artifacts in the IHE/fhir repo
https://github.com/IHE/fhir

All of the NPFS artifacts need to be created in your new ITI.NPFS IG, and thus in the canonical space of the ITI.NFPS IG.

I noticed that the NPFS codesystem is not in the new IG
https://github.com/IHE/fhir/blob/master/CodeSystem/codesystem-IHE_NPFS_classcode.xml

When we publish ITI.NPFS in the IG form, we will remove these artifacts from the IHE/fhir repository.

Section Number Identify the most specific section number the issue occurs (e.g. 4.1.2)

47.1

Issue Describe your issue. Don't write a book, but do include enough to indicate what you see as a problem.

Table 47.1-1, and the paragraph above it, was not copied from the PDF to the IG. This table is responsible for declaring the transactions that the NPFS actors are required to support.

Proposed Change Propose a resolution to your issue (e.g., suggested new wording or description of a way to address the issue). The committee might simply accept your suggested text. Even if they don't, it gives a good sense of what you are looking for. Leaving this blank means you can't imagine how to resolve the issue, which makes it easier for the committee to admit they can't imagine how to resolve it either and leave it unresolved.

Copy the table from the PDF.

Priority:

• Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.