iftekhersunny / go_country Goto Github PK
View Code? Open in Web Editor NEWCountry is the package that helps you to get country name and dialling code by the country ISO 3166-1 Alpha-2 code.
License: MIT License
Country is the package that helps you to get country name and dialling code by the country ISO 3166-1 Alpha-2 code.
License: MIT License
Hi,
DO you think it is possible to add a function:
// Read countries data file
func (country *Country) readCountriesExternalDataFile(dataFileName string ) *Country {
if len(country.data) > 0 {
return country
}
dataPath, _ := filepath.Abs(dataFileName)
file, _ := ioutil.ReadFile(dataPath)
json.Unmarshal([]byte(file), &country.data)
return country
}
For build in project.
Thank you
Running golint .
on this project gives a number of warnings, including warnings on package name containing an underscore.
Maybe run golint .
and see what you think?
Instead of using a JSON file that can have a ton of different paths, why not just create a map that loads upon construction of type Country
.
dataPath, _ := filepath.Abs("./data/countries.json")
This is bad practice.
In functions GetDialingCode
and GetName
, return strings rather than interfaces to make it simpler.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.