Action breaks when a user is invited more than once about outside-collaborators HOT 2 CLOSED

@jschanfung, actually, the following snippet should guarantee that there won't be any conflicts in case of multiple invitations of the same user:

https://github.com/icub-tech-iit/outside-collaborators/blob/master/scripts/outside-collaborators-handler.rb#L123-L136

from outside-collaborators.

Hi @jschanfung

Did you manage to test it in a real scenario or are you speculating about the pitfall?

Users and groups get processed serially, hence user03 should receive the permission that comes as last.

That said, I didn't cover all the possibilities while developing this system honestly, and it might be that inviting twice the same user in a row can generate conflicts. Differently, when you just change permissions for users/groups who have already accepted the invitation, there are no conflicts.

It's not that straightforward to test this condition as I'd need an external collaborator to help me with that, but I'll have a look.
Thanks for pointing it out.

from outside-collaborators.