Code Monkey home page Code Monkey logo

Comments (5)

cschroeter avatar cschroeter commented on May 28, 2024 2

This is only an issue for "@types/react": "18.2.67"

For a workaround you can downgrade to 18.2.62 - if only React would have been written in TypeScript...

from react-simple-icons.

jd-carroll avatar jd-carroll commented on May 28, 2024

Just did some additional investigating and I do not see either of those attributes defined in @types/react
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/2f4238e22773624585ec81994bf54ef9873f5e2c/types/react/ts5.0/index.d.ts#L2487-L2488

(which is why those types come up as untyped required attributes)

But how has no one else run into this issue?

from react-simple-icons.

jd-carroll avatar jd-carroll commented on May 28, 2024

Last thing, wouldn't it be better to structure IconType as:

type IconType = React.ForwardRefExoticComponent<
  Omit<React.SVGProps<SVGSVGElement>, 'title' | 'color' | 'size'> & {
    title?: string;
    color?: string;
    size?: string | number;
  } & React.RefAttributes<SVGSVGElement>
>;

from react-simple-icons.

sfyr111 avatar sfyr111 commented on May 28, 2024

Hello everyone,

I've submitted a PR #216 that aims to resolve the type error issue highlighted in issue #215 by removing the onPointerEnterCapture and onPointerLeaveCapture from the type declarations, syncing with the recent updates to React's type definitions. I would greatly appreciate any feedback or suggestions on this solution.

Thank you for your time and looking forward to any further discussion!

from react-simple-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.