v5.2.0 tree shaking doesn't work as intended about react-simple-icons HOT 18 CLOSED

thanks @wootsbot, it solved the situation.

I was wondering, would it be a possible to import icons individually?

import SiGithub from "@icons-pack/react-simple-icons/Github" //or something

This has the advantage of being very explicit, while also giving faster build times because the bundler does not have to tree shake the entire package in every file where an icon is imported (looking at you MUI).

from react-simple-icons.

@AbdBarho I'm working on a compiled refactor, I think at the moment it can help to solve

#140 (comment)

This works for now. Hoping to see a proper resolution for the v7s soon

from react-simple-icons.

@AbdBarho I'm working on a compiled refactor, I think at the moment it can help to solve

#140 (comment)

from react-simple-icons.

@AbdBarho I'm working on a compiled refactor, I think at the moment it can help to solve
#140 (comment)

This works for now. Hoping to see a proper resolution for the v7s soon

This has been resolved in version v8.0.1.

from react-simple-icons.

Is simple-icons/simple-icons#8112 possibly related? I can confirm that this is an issue for me and prevents my Remix app from deploying on CF Pages (bundle size is > 1MB when using a few icons).

Edit: Downgrading to 5.11 fixes the issue.

from react-simple-icons.

@aflatter @skyclo I am checking with version v7.1.1 I have a tree correctly

Just tried 7.1.1, same problem:

foo@bar aflatter % npm run build

> [email protected] build
> next build

info  - Linting and checking validity of types  
info  - Compiled successfully
info  - Collecting page data  
info  - Generating static pages (4/4)
info  - Finalizing page optimization  

Route (pages)                              Size     First Load JS
┌ ○ /                                      1.63 MB        1.71 MB
├   /_app                                  0 B            73.3 kB
├ ○ /404                                   182 B          73.4 kB
├ ○ /about                                 1.6 kB         80.1 kB
└ λ /api/hello                             0 B            73.3 kB
+ First Load JS shared by all              75.6 kB
  ├ chunks/framework-2c79e2a64abdb08b.js   45.2 kB
  ├ chunks/main-0ecb9ccfcb6c9b24.js        27 kB
  ├ chunks/pages/_app-ae907860a06fe57a.js  296 B
  ├ chunks/webpack-8fa1640cc84ba8fe.js     750 B
  └ css/5983c06de8f68d75.css               2.37 kB


foo@bar aflatter % git diff package.json
diff --git a/package.json b/package.json
index 572584b..78a7a57 100644
--- a/package.json
+++ b/package.json
@@ -9,21 +9,21 @@
     "lint": "next lint"
   },
   "dependencies": {
-    "@icons-pack/react-simple-icons": "^5.3.0",
+    "@icons-pack/react-simple-icons": "^7.1.1",
     "@types/node": "18.14.6",
     "@types/react": "18.0.28",
     "@types/react-dom": "18.0.11",
     "eslint": "8.35.0",
     "eslint-config-next": "13.2.3",
-    "next": "13.2.3",
+    "next": "^13.2.4",
     "react": "18.2.0",
     "react-dom": "18.2.0",
     "sharp": "^0.31.3",
     "typescript": "4.9.5"
   },
   "devDependencies": {
-    "autoprefixer": "^10.4.13",
+    "autoprefixer": "^10.4.14",
     "postcss": "^8.4.21",
-    "tailwindcss": "^3.2.7"
+    "tailwindcss": "^3.3.1"
   }
 }

from react-simple-icons.

This has been resolved in version v8.0.1. I have had the opportunity to submit this refactoring. Please, feel free to report if you encounter any issues.

from react-simple-icons.

I have now downgraded to v4.7.2 and tree shaking works properly. I'm guessing something is not configured correctly in the new Rollup config in this commit 362600c

from react-simple-icons.

Fixed in v5.3.0

from react-simple-icons.

Awesome, thanks for making a release!

from react-simple-icons.

This issue seems to be back since v.6.0.0

from react-simple-icons.

It is :/

from react-simple-icons.

@sch-28 Can you show the results with the latest version?

from react-simple-icons.

Edit: Downgrading to 5.11 fixes the issue.

Thanks, I just downgraded to 5.30 and it works for me.

from react-simple-icons.

If I have suffered my own mistake, working on it.

from react-simple-icons.

@aflatter @skyclo I am checking with version v7.1.1 I have a tree correctly

import {
  SiReact,
  Si1001tracklists,
  SiAbbott,
  Si1password,
} from "@icons-pack/react-simple-icons";

function IconsPage() {
  return (
    <div>
      <SiReact color="#61DAFB" size={24} />
      <Si1001tracklists color="#61DAFB" size={24} />
      <SiAbbott color="#61DAFB" size={24} />
      <Si1password color="#61DAFB" size={24} />
    </div>
  );
}

export default IconsPage;

from react-simple-icons.

Just tried 7.1.1, same problem:

Let me replicate your settings, I'll do some deeper tests

from react-simple-icons.

We are also facing the same problem:

https://github.com/LAION-AI/Open-Assistant/tree/main/website

"@icons-pack/react-simple-icons": "^7.2.0"

from react-simple-icons.