iceddev / cooldux Goto Github PK

Instead of import { resetReducer } from cooldux :

export const { someAction, someOtherAction, initialStateCombined } = duck;

const reducer = resetReducer(initialStateCombined, (state = initialStateCombined, action) => {
  return duck.reducerCombined(state, action);
});

export default reducer;

It should be as simple as:

export const { someAction, someOtherAction } = duck;

export default duck.resetReducer;

you can still the former example if you need custom reducer functionality. Just finding myself using the same reset pattern too often

More of a discussion than a bug but:
https://github.com/iceddev/cooldux/blob/master/index.js#L46

Here promiseHandler ends up gobbling up errors. Which means if I have a create method using it inside of a react component like so:

createMethod(someData)
  .then((success) => {
     this.setState({
       msg: 'thing successfully created'
     })
   })

It will always say thing was created. I'd prefer to explicitly handle the error myself by rethrowing it rather than just returning null, however I can see why some people might prefer the existing implementation.

How do you feel about throwing here vs returning the null?

We often make an action such as fetchIfNeeded() that checks the state first.

We could have the cooldux middleware do that if our actions were wrapped in a checkCache() type of function or potentially if cooldux options had a checkCache flag

Documentation could probably be improved in the following areas:

• combinedHandler needs to be explained.
• Setting initialState with the various components, maybe an "initialState" section.
• Examples Examples Examples
• API documentation in a jsDoc fashion.

since we're never referencing it directly in a single duck, make it easier and increment a counter or something.

this can make it more difficult to debug if you're counting on action names, but yo: devtools, breakpoints, console.log etc.