icarus-sullivan / react-spinner-material Goto Github PK

https://github.com/icarus-sullivan/react-spinner-material/blob/master/src/helpers.js#L84 causes a random id which causes snapshot updates - leading to test failures.

At a glance, I think the whole id assignment can be skipped but I might be overlooking things.

At a minimum, if the id generation can be made deterministic, this won't be an issue.

You need to select a license if you want anyone to make use of this.

React version: 15.6.1
react-spinner-material version: 1.0.15

Getting warning in console of developer tools...

Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in React
v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage,
compatibility, migration and more, see https://fb.me/prop-types-docs

The prop-types package is required when v16 of React releases.

When using TypeScript all props are required even though there are defaults.
This should be a super easy fix and I can just create a PR if you'd like.

Hi, I'd like to report a problem of latest version 1.1.2 with typescript.

react: 16.9.0 (@types/react 16.9.2)
react-dom: 16.9.0 (@types/react-dom 16.8.5)
typescript: 3.5.3
react-spinner-material: 1.1.2

 TypeScript error in ....(xxx,xxx):
 JSX element type 'false | Element' is not a constructor function for JSX elements.
  Type 'false' is not assignable to type 'Element | null'.  TS2605

It seems that Spinner component should not return false.

Greetings!
Last version of react-spinner-material (1.0.14) breaks webpack build.
Here is error:
ERROR in ./~/react-spinner-material/lib/index.js Module not found: Error: Can't resolve './index.css' in '***/node_modules/react-spinner-material/lib' @ ./~/react-spinner-material/lib/index.js 17:0-22