Code Monkey home page Code Monkey logo

client-go-helper's Introduction

Hi ๐Ÿ‘‹, I'm ica10888

I am a software developer

I am interested in kubernetes , devops , functional programming and more

My most commonly used programming languages are Java , Golang and Python

Learning Rust !

GitHub stats

client-go-helper's People

Contributors

ica10888 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

client-go-helper's Issues

Error should be returned in case Do func failled while init client

Context

The function InitClient from package client:

func InitClient() (*kubernetes.Clientset, error) {

Actual behavior

// use sync.Once, so clientset can only init once
func InitClient() (*kubernetes.Clientset, error) {
	var once sync.Once
	var clientset *kubernetes.Clientset
	once.Do(func() {
		log.Print("start doInit()")
		clientset, _ = doInit()
	})
	return clientset, nil
}

Here, if the function once.Do failled because of doInit function, the error isn't catched.

Suggestion

// use sync.Once, so clientset can only init once
func InitClient() (*kubernetes.Clientset, error) {
	var once sync.Once
	var clientset *kubernetes.Clientset
        var err error
	once.Do(func() {
		log.Print("start doInit()")
		clientset, err = doInit()
	})
        if err != nil {
		return nil, err
	}
	return clientset, nil
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.