Code Monkey home page Code Monkey logo

auth-ms-openliberty's People

Contributors

phemankita avatar

Watchers

 avatar  avatar

auth-ms-openliberty's Issues

minimize the amount of info on an unsuccessfull login attempt.

I have inspected the HTTP response.

Tampering with the username / password gives
{
"error_description": "invalid_resource_owner_credential",
"error": "server_error"
}

Tampering with the client secret or id gives:
{
"error_description": "CWWKS1406E: The token request had an invalid client credential. The request URI was /oidc/endpoint/OP/token.",
"error": "invalid_client"
}

It is better to give out as little as information as possible to a would be attacker.

Would it be possible to change the error response message to "authentication failed"?

improve logging

During tampering with the login I see:

[ERROR ] CWOAU0069E: The resource owner could not be verified. Either the resource owner: foo or password is incorrect.
[ERROR ] CWOAU0038E: The client could not be verified. Either the client ID: bluecomputeweb or client secret is incorrect.

It is best practice to log no personal data as such information can be misused.

Would it be possible to change the code to log that an invalid login attempt occurred from a specific IP address? In that case it would be possible to block that IP address in the WAF.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.