ianthehenry / cmd Goto Github PK

...and -h too, probably.

We should actually probably accumulate flags and only look at positional arguments.

For this example program:

(import cmd)

(cmd/main (cmd/fn
  [--greeting (optional :string "Hello")
   name :string]
  (printf "%s, %s!" greeting name)))

When run as a script using janet main.janet works as expected, but when compiled using jpm quickbin main.janet example and run we get this error:

error: bad slot #1, expected string, symbol, keyword or buffer, got nil
  in string/split [src/core/string.c] on line 445
  in is-probably-interpreter? [/opt/homebrew/Cellar/janet/1.30.0/lib/janet/cmd/util.janet] on line 78, column 12
  in args [/opt/homebrew/Cellar/janet/1.30.0/lib/janet/cmd/arg-parser.janet] on line 148, column 9
  in main [main.janet] on line 6, column 1

It seems like the focus of cmd at present is on shebang-style Janet scripts. But I'm trying to build native executables with jpm. I haven't been able to get even a "Hello, World" working based on the instructions in the README. Could you please point me in the right direction?

I notice that when a command doesn't have a docstring, its hyphen separator in the formatted help text prints misaligned from the other commands:

It almost looks like this is done on purpose in help.janet:

If it wasn't for that empty? check, the hyphen would always align regardless. So that makes this behavior look intentional.

I'm curious why?