iamsalnikov / socache Goto Github PK

Here's a list of quibbles and complaints. I'll update it as I find stuff.

• Why are the flags global variables if they're only ever used in main()? They're polluting the global namespace for no particular reason.

https://github.com/iamsalnikov/socache/blob/master/server.go#L24

Maybe just call these funcs vk.New() and facebook.New(), you already got the name in the package.
https://github.com/iamsalnikov/socache/blob/master/cleaners/cleaner_interface.go
You should rename the file and the interface to clearer/Clearer or (cleaner/Cleaner && rename the func in the interface to Clean). This is according to nearly all single func interfaces in the stdlib, like io.Reader, io.Writer, json.Marshaler etc.

You got a dependency to github.com/asaskevich/govalidator where you in fact just use !govalidator.IsURL. According to idiomatic go, you should replicate small functionality instead of depending on another package, example for this are found in the stdlib.

I don't get the point why easyjson is used, but i haven't looked into it though. Isn't a simple json.Marshal or json.Unmarshal / json.Encoder / json.Decoder sufficient? Maybe in use with https://mholt.github.io/json-to-go/ to generate the structs automatically.