iamgreaser / libit216 Goto Github PK

As evidenced by not just the Storlek tests but by other random things I have lying around.

This is pretty much the ultimate Song From Hell. It uses a lot of effects that nobody else ever uses ever (read: the S7x block). Once this works, every bug is fixed. Ever. Or something like that.

• Getting enough semi-stuck notes to make the sound peak when the bass comes in.
• Some of the strings are getting stuck.
• Early distorted guitar lead seems to fade at one point when it shouldn't (DCT/NNA bug?) - this may be correct behaviour, I'm mostly going by memory.
• Quiet guitar lead section seems to jack up the volume oddly.
• Premature fades after the quiet guitar lead section, onto the string section, in the strings. May be S7x-related.
• Stuck distorted guitar after that section.
• Distorted guitar seems to be prematurely fading now.
• Stuck distorted guitar after that section.
• Whatever else is discovered.

ko0x's "the living umbrella" and "riding on a rainbow" have this issue and are both in sample mode, which suggests either a faulty effect, faulty processing, or incomplete initialisation of fields.

CJA's grd-spr/grd-aut are also affected.

It appears to be an issue with the Dx voleffect.

Un-MMCMP'd version, of course. This is the IT 2.08 demo tune.

Piano (ins=04) has NNA=Fade, DCT=Fade/Smp.

This probably affects a lot of things, including CHRIS31B.

Narrowing this down, this may actually be an issue with fadeout in general or at least NNA fadeout, as the issue persists even when DCTs are force-ignored.

WARNING: This track doesn't even work in Impulse Tracker (it crashes when you hit play), so I'm only focusing on the blatant issues. I have fixed this track such that it plays in IT 2.14p5 without issues. At least as far as I know. I'm almost a minute in and it's a ~30-min track.

• A lot of notes fail to allocate at all. NOT A BUG, THIS TRACK FALSELY MARKS INSTRUMENTS AS MIDI WHICH DOES NOT PLAY ON THE MIXER IN IT ITSELF (I have another track which has this issue too which DOES play in IT)
• Whatever else is discovered.

In other words, ConvertOldInstrument needs to be ported.

campana, dbt, and fifty are broken. This is probably due to THAT FUCKING OFF-BY-ONE ISSUE.

Currently using some stuff I made before it was released. With the actual mixer code put in place it should be possible to switch between the mixer types and get filters working.

Simplest mixer is MONO12B.MIX.

It's quite likely that we won't bother with unrolling the loops - the compiler can do that for us.

Check src/sdriver/drv_oss.c and when you find the line that sets drv.DriverFlags, set it to 2 (or 3 if you don't mind seeing MIDI output). One of the notes sticks really, really early on.

I don't actually know what HiQual mode is for right now.

Current known list of issues with this track:

• Global volume slide is a bit too slow
• Notes tend to fade prematurely around the start (related to #7?)
• Pads seem to cut out before the lead repeats in harmony
• Stuck note on the cymbal
• Strings tend to note-cut before the guitar comes in
• Premature fading on the flute when the guitar comes in
• Synth lead prematurely cuts out, even though the transition to distorted guitar mostly holds (MOSTLY. It breaks later) - could be mixer-related?
• After all that synth + distgut stuff, strings tend to notecut
• Lots of stuff cuts out close to the end when it starts winding down
• Whatever else is discovered.

Current suspect: NNA/DCT new channel allocation may be stealing channels it shouldn't. Upping the channel count from 128 to 256 seems to result in more or less the same crap, so probably not an exhaustion issue.

Currently we call D_LoadIT to load a file, which assumes it's an unaffected IT file.

The MMCMP stuff is useful for grabbing tracks from old versions of IT.

The other demo track.

• A few stuck notes near the start
• A few stuck notes near the middle
• Whatever else is discovered.

Noticing it on qualo's "kakapo mating", but also on some other things too.

Not sure if this is actually a "feature", but I do suspect it is actually a bug. It's probably not supposed to be that out of tune.

Drops are on the lead. This is an instrument-mode track.