hyperadev / scaffolding Goto Github PK

Describe the bug
MCEdit schematics are loaded with a different block pallet when compared to how WorldEdit handles the same schematic. Currently, state Ids can only go from 0 to 255 if addBlocks is not used. This is an issue since Minestom block state Ids can go up to ~15000. To fix the issue, blockId and blockData should be mapped together to get the true stateId, such as how WorldEdit does.

I have a have a solution that just needs to be cleaned up when I have a bit of free time. I just wanted to create an issue so I can resolve it ;)

The schematic should be building at/around the area where the schematic was saved from.

The schematic is saved using WorldEdit on Fabric like so

However when the schematic is pasted with schematic.build(spawnInstance, new Pos(0, 100, 0)) the schematic is actually built with the centre emerald block at 9, 119, 8 instead of 0, 99, 0

Readme specifies com.crystalgames as the group id whereas the actual group id is net.crystalgames

I have a schematic created and loaded which contains Signs with Text on it.
The Signs on loading does not have a Text

Does Schematics contain the Text of the Signs? if yes -> They dont get loaded correctly (I have BlockHandler for Signs registered)

This is an issue so I can remember to make this project MIT license when I wake up.

Describe the bug
So when you trying to load up a schematic via Scaffolding.fromFile or via the FileInputStream the response is always null. There is no exception too which would be thrown. BTW my entire completeable future is beeing closed but i have no idea what why and whats caused it...

To Reproduce
Steps to reproduce the behavior:

1. Load up a schematic
2. look via if(schematic != null) if its null
3. Use it in a CompleteableFuture
4. See null response with no error (Schematics are tested and worked fine)

Expected behavior
It should throw an error and should load when the schematics are right, load them up.

Screenshots
1.

2. (Debug)

(- Please ask for a full code snippet)

Desktop (please complete the following information):

• Latest Scaffolding version
• Latest Minestom verison (Not 1.18 branch)
• Java 17

Describe the bug
When placing a schematic it produces:

java.lang.ArrayIndexOutOfBoundsException: Index 1048576 out of bounds for length 24
	at java.base/java.util.ImmutableCollections$ListN.get(ImmutableCollections.java:680)
	at net.minestom.server.instance.DynamicChunk.getSection(DynamicChunk.java:109)
	at net.minestom.server.instance.Chunk.getSectionAt(Chunk.java:95)
	at net.minestom.server.instance.DynamicChunk.setBlock(DynamicChunk.java:72)
	at net.minestom.server.instance.batch.ChunkBatch.apply(ChunkBatch.java:216)
	at net.minestom.server.instance.batch.ChunkBatch.singleThreadFlush(ChunkBatch.java:188)
	at net.minestom.server.instance.batch.ChunkBatch.lambda$apply$0(ChunkBatch.java:156)

To Reproduce
Steps to reproduce the behavior:

Schematic schem = Scaffolding.fromFile(...);
schem.build(..., Pos.ZERO);

(unpack for schematic, WE is ok with it, and it seems to have everything expected)
lightouse.schem.zip

Expected behavior
should build

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]
  ah yes very good

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]
  +1 for template

Additional context
Add any other context about the problem here.