Code Monkey home page Code Monkey logo

scaffolding's People

Contributors

damiankocher avatar joshuasing avatar loofifteen avatar rqver avatar technerder avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

scaffolding's Issues

Use a license

This is an issue so I can remember to make this project MIT license when I wake up.

Null response without an error

Describe the bug
So when you trying to load up a schematic via Scaffolding.fromFile or via the FileInputStream the response is always null. There is no exception too which would be thrown. BTW my entire completeable future is beeing closed but i have no idea what why and whats caused it...

To Reproduce
Steps to reproduce the behavior:

  1. Load up a schematic
  2. look via if(schematic != null) if its null
  3. Use it in a CompleteableFuture
  4. See null response with no error (Schematics are tested and worked fine)

Expected behavior
It should throw an error and should load when the schematics are right, load them up.

Screenshots
1.
image
2. (Debug)
image
(- Please ask for a full code snippet)

Desktop (please complete the following information):

  • Latest Scaffolding version
  • Latest Minestom verison (Not 1.18 branch)
  • Java 17

MCEdit schematics use the incorrect block pallet

Describe the bug
MCEdit schematics are loaded with a different block pallet when compared to how WorldEdit handles the same schematic. Currently, state Ids can only go from 0 to 255 if addBlocks is not used. This is an issue since Minestom block state Ids can go up to ~15000. To fix the issue, blockId and blockData should be mapped together to get the true stateId, such as how WorldEdit does.

I have a have a solution that just needs to be cleaned up when I have a bit of free time. I just wanted to create an issue so I can resolve it ;)

Schematics don't paste at correct location

The schematic should be building at/around the area where the schematic was saved from.

The schematic is saved using WorldEdit on Fabric like so
image

However when the schematic is pasted with schematic.build(spawnInstance, new Pos(0, 100, 0)) the schematic is actually built with the centre emerald block at 9, 119, 8 instead of 0, 99, 0

image

image

Sign Bug?

I have a schematic created and loaded which contains Signs with Text on it.
The Signs on loading does not have a Text

Does Schematics contain the Text of the Signs? if yes -> They dont get loaded correctly (I have BlockHandler for Signs registered)

Cannot place schematic

Describe the bug
When placing a schematic it produces:

java.lang.ArrayIndexOutOfBoundsException: Index 1048576 out of bounds for length 24
	at java.base/java.util.ImmutableCollections$ListN.get(ImmutableCollections.java:680)
	at net.minestom.server.instance.DynamicChunk.getSection(DynamicChunk.java:109)
	at net.minestom.server.instance.Chunk.getSectionAt(Chunk.java:95)
	at net.minestom.server.instance.DynamicChunk.setBlock(DynamicChunk.java:72)
	at net.minestom.server.instance.batch.ChunkBatch.apply(ChunkBatch.java:216)
	at net.minestom.server.instance.batch.ChunkBatch.singleThreadFlush(ChunkBatch.java:188)
	at net.minestom.server.instance.batch.ChunkBatch.lambda$apply$0(ChunkBatch.java:156)

To Reproduce
Steps to reproduce the behavior:

Schematic schem = Scaffolding.fromFile(...);
schem.build(..., Pos.ZERO);

(unpack for schematic, WE is ok with it, and it seems to have everything expected)
lightouse.schem.zip

Expected behavior
should build

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
    ah yes very good

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]
    +1 for template

Additional context
Add any other context about the problem here.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.