Code Monkey home page Code Monkey logo

safe-app-base's People

Contributors

appins avatar bhaveshgohel avatar bokuweb avatar clemens-tolboom avatar dabrown95 avatar fscherwi avatar galeksandrp avatar haacked avatar hunterlester avatar icodeforbananas avatar icoxfog417 avatar ionicabizau avatar izuzak avatar jlord avatar kevinsawicki avatar laiso avatar louis993546 avatar phanect avatar posva avatar pratu16x7 avatar sahildua2305 avatar tcyrus avatar thompsonemerson avatar zanesterling avatar zeke avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

rdewilde-ion

safe-app-base's Issues

Mock routing support

I am using this with the latest SAFE Browser, v0.8.0 with mock support. The app never receives an 'auth-response' from the SAFE Browser after you authenticate in the browser. Is this an issue with this app or does it just not support mock routing? Any help you can give would be greatly appreciated.

`npm install` fails on Linux 64, `yarn install` works

Using commit 0512dc1.

The README.md says:

# Set env variable for mock routing
*nix: `set NODE_ENV='dev'`, Windows: `$env:NODE_ENV = 'dev'`
# Install dependencies
npm install

On Linux 64-bit, I tried the following:

export NODE_ENV=dev
npm install

Note that export does the same thing as set above. I get the following error:

Downloading tmp-10713-1-safe_app-mock-v0.4.0-linux-x64.zip
[============================================>] 100.0% of 3.32 MB (1.02 MB/s)
Downloaded and unzip of safe_app-mock complete: 
 - src/native/libsafe_app.so




> [email protected] postinstall /home/mint/Downloads/m1/safe-app-base/node_modules/electron
> node install.js


> [email protected] postinstall /home/mint/Downloads/m1/safe-app-base
> npm run build-safe-app && npm run rebuild


> [email protected] build-safe-app /home/mint/Downloads/m1/safe-app-base
> cd node_modules/safe-app && npm install

sh: 1: cd: can't cd to node_modules/safe-app

npm ERR! Linux 4.4.0-53-generic
npm ERR! argv "/home/mint/.nvm/versions/node/v7.10.1/bin/node" "/home/mint/.nvm/versions/node/v7.10.1/bin/npm" "run" "build-safe-app"
npm ERR! node v7.10.1
npm ERR! npm  v4.2.0
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build-safe-app: `cd node_modules/safe-app && npm install`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] build-safe-app script 'cd node_modules/safe-app && npm install'.

The key bit in the error: sh: 1: cd: can't cd to node_modules/safe-app. I checked by hand and node_modules/safe-app is absent.

Since every project seems to be moving towards using yarn, I tried the following just for fun.

export NODE_ENV=dev
yarn install

Yarn ran a bunch of tests, ran through all the post-install stuff, and completed after 388.53 seconds. I was then able to run npm start or yarn start (both worked the same way): the app executed without any problem.

It looks like the README.md should be updated to make use of yarn over npm. I'd be happy to submit a PR with s/npm install/yarn install/g in the README if that makes it easier.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.