hungpk / blockchain_w1 Goto Github PK

Project 1 Grading

Thanks for the good GIF.

Intro

Thanks for completing this assignment. The goal was to have you deploy your first smart contract on Solidity, learning some of the common tasks you'll need along the way. You should also by now be familiar with the mapping data type, and payable functions.

Requirements

Good job! Your contract fills the requirements - you check the max tickets, the minimum bet, and distribute the prizes once the game is done.

Oh no, but you forgot to reset the game after each run. Remember your contract lasts forever, so you should clean it up. I also like that you tried to charge a fee...it would've been cool if you had done that.

UI

It is cool that you did showPlayers.