hunesion / ossnacclient Goto Github PK

View Code? Open in Web Editor NEW

21.0 17.0 19.0 8.13 MB

이 프로젝트는 사용자 단말의 안정성을 확보하여 내부 네트워크에 접근을 허용하는 개방형OS 기반의 네트워크접근통제 클라이언트를 개발합니다.

License: GNU Lesser General Public License v2.1

CMake 9.02% C++ 76.43% Shell 0.44% C 1.38% CSS 0.41% HTML 12.01% Makefile 0.31%

nac networkaccess openos

ossnacclient's People

Contributors

Stargazers

Watchers

Forkers

huneopenup eunah0707 eunah07 darksaverver hns10050 rioph choiyunkyoung jcmsimba ahnbc00 danmured hns10109 dainchoi-hunesion leejekyoung ahnbyungchul formerlymisterfriese mdsnins qubcia rectcoordsystem dnyang72

ossnacclient's Issues

About commented codes

I found that there are some commented codes without any explanation in "nacapplication.cpp". So, I suggest writing some comments about those codes. (or removing them if they are no longer used)

ossNacClient/nac_client/src/ui/nacapplication.cpp

Lines 115 to 122 in 8a8a243

    
           Hune::Core::hune_core_init(); 
        
           hune_event_callback_init(); 
        
           // ftc_dbus_server_init();  
        
           //g_action_map_add_action_entries(G_ACTION_MAP(app), app_entries, G_N_ELEMENTS(app_entries), app); 
        
           gtk_application_set_accels_for_action(GTK_APPLICATION(app), "app.quit", quit_accesls);

Also, there are some commented debugging codes in "main.cpp". I also suggest using some other method to disable debug codes (e.x. #ifdef) instead of commenting them out.

ossNacClient/nac_client/src/main.cpp

Lines 10 to 15 in 8a8a243

    
           //HUNE_LOG("Main Application Started");  
        
           app = nac_application_new();  
        
           if (app == NULL) return rv ;  
        
           rv =  g_application_run(G_APPLICATION (app), argc, argv); 
        
           g_object_unref(app);  
        
           //HUNE_LOG("Main Application End");

Add tests for modules

I suggest to add tests for testing modules of this project. Recommendation: Google test for C++: https://docs.microsoft.com/ko-kr/visualstudio/test/how-to-use-google-test-for-cpp.

We can run unit tests per module. For example, we can add encryption/decryption tests for crypto.cpp.

Mixed usage of NULL and nullptr

I found that there are some files are using NULL for assigning null to pointers and some files are using nullptr for it. Moreover, It seems that "DirectoryMonitor.cpp" uses both two methods in one code.

ossNacClient/nac_client/src/core/DirectoryMonitor.cpp

Lines 91 to 110 in fc3b928

    
           DmParam *dmParam = NULL; 
        
           if (! eventMgr) { 
        
               return; 
        
           }    
        
           dmParam = new (std::nothrow) DmParam(); 
        
           if (!dmParam) { 
        
               return; 
        
           } 
        
           dmParam->dir = this->_dir; 
        
           dmParam->filename = event->name; 
        
           dmParam->mask = event->mask; 
        
           dmParam->userData = this->_userData; 
        
           eventMgr->dispatchEventAsync(this->_eventName.c_str(), dmParam, [](void *data) { 
        
               if (data) { 
        
                   DmParam *param = (DmParam*)data; 
        
                   delete param; 
        
                   param = nullptr;

Therefore, I suggest using consistent method for assigning null to pointer.

Integrate Linter or Code Formatter

Seems like the code style / format of this project differs by source files, thus sometimes it is hard to read and understand codes.

To encourage source contribution, I recommend to integrate code linter (or formatter) on this project.

See the best practices of C/C++ Linters: https://github.com/caramelomartins/awesome-linters#cc

Suggestion to avoid C style casting

For more efficient code maintenance, I recommend to avoid C style casting (such as (struct struct_name *) void_ptr)

There are several reasons why C++ style casting should be used instead of C style casting. (Also mentioned in #56 too)

C style castings are not checked at compile time and therefore causes some problem on runtime (And they are usually hard to debug)
C++ style castings enhance the readability of the entire code by enabling searching code snippets by the common postfix _cast.
C++ style castings support more precise casting, based on the context.

Instead, I suggest to jenkins or Github Actions.

hunesion / ossnacclient Goto Github PK

ossnacclient's People

Contributors

Stargazers

Watchers

Forkers

ossnacclient's Issues

About commented codes

Add tests for modules

Mixed usage of NULL and nullptr

Integrate Linter or Code Formatter

Suggestion to avoid C style casting

Policy Script Synchronization Issues

Documentation for build

Suggestions for NAC end-user status classification

Consider scalability for INIManager

Add CI/CD

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	Hune::Core::hune_core_init();
	hune_event_callback_init();
	// ftc_dbus_server_init();

	//g_action_map_add_action_entries(G_ACTION_MAP(app), app_entries, G_N_ELEMENTS(app_entries), app);

	gtk_application_set_accels_for_action(GTK_APPLICATION(app), "app.quit", quit_accesls);

	//HUNE_LOG("Main Application Started");
	app = nac_application_new();
	if (app == NULL) return rv ;
	rv = g_application_run(G_APPLICATION (app), argc, argv);
	g_object_unref(app);
	//HUNE_LOG("Main Application End");

	DmParam *dmParam = NULL;
	if (! eventMgr) {
	return;
	}

	dmParam = new (std::nothrow) DmParam();
	if (!dmParam) {
	return;
	}

	dmParam->dir = this->_dir;
	dmParam->filename = event->name;
	dmParam->mask = event->mask;
	dmParam->userData = this->_userData;

	eventMgr->dispatchEventAsync(this->_eventName.c_str(), dmParam, [](void *data) {
	if (data) {
	DmParam param = (DmParam)data;
	delete param;
	param = nullptr;