hummingbird-me / kitsu-web Goto Github PK

(Optional) Ability to give points for story, characters, music/audio effects, and visuals separately. This is the main reason I keep using Anilist instead of Kitsu.

Hello,
Like to make a proposal to expand a bit on the component for v4 button component as part of laying the foundation for the future. All observable styles in v3 (and more as v4 expands) will have the styling logic be included in the component by passing the required and optional props. Abstracting and encapsulating a range of styles can safe guard against developer's altering brand design consistency. While it's still possible to cascade styles from parent component, the constraints should make it become the last resort.

Figma link serves as a visual proposal and examples for the few button types and customizability + additional reasoning.
https://www.figma.com/file/zaPBj1kYY7bZ7NTC3HDnkU/Kitsu-Buttons?node-id=10%3A286

I can implement something for review, but if things are already set in stone, it's okay too.

Adhere to https://stackoverflow.com/revisions/52986538/21#:~:text=Preview%20Release%2068-,In%20case%20user%20preference,color%3A%20black%3B%0A%20%20%20%20%20%20%20%20color%3A%20white%3B%0A%20%20%20%20%7D%0A%7D,-There%20is%20also so that I don't need to manually modify https://kitsu.io/settings/profile#:~:text=Content%20on%20Kitsu-,site%20theme,-Light%20Theme every time my OS+browser's theme changes.

Because Ember apps are statically generated, you can't use dynamic meta tags, even if you set them after the application loads (what Kitsu currently does). This does not work for almost all sites, as they would only fetch the HTML and not execute it, therefore the meta tags are never generated.

Is this known, or is this not very important?

I refer to https://kitsu.io/users/rokejulianlockhart#:~:text=favourite%20anime%2Fmanga-,about%20me,-%60%60%60pwsh%0AInvoke-WebRequest. A subset of simple things like quotes, fenced code blocks and links would satisfy 99% of people if things like HTML support isn't desirable.

Dependent upon #2342 (comment).

As https://kitsu.io/posts/9820894 (content duplicated from https://github.com/mxstbr/markdown-test-file/blob/02352575b91987a513e0d573a41b7637280dc228/TEST.md?plain=1) demonstrates, there is no Markdown formatting support. I believe that it should be present, because there is no other formatting support available.

Counterpart to https://myanimelist.net/forum/?topicid=2155172.

Whenever you fetch data, the Suspense element at the root catches that and the header and content disappears until it's finished fetching content. Disabling the context.suspence from the query ends up making it reload the component in an infinite loop.

User profiles have a header

For instance, https://kitsu.io/anime?categories=science-fiction,violence, even with every filter set to its broadest, displays no more than 20 results.

Visiting my own group settings through the group dashboard gives a 404.

Such as: https://kitsu.io/groups/GROUP_NAME/dashboard/settings

Browser: Firefox Version 111.0 (64-bit)

Not sure if this helps, but the Firefox developer menu's network tab shows this line when clicking 'Settings'. Maybe it's fetching the wrong file? 'group-categories' doesn't sound right to me.

https://kitsu.io/users/rokejulianlockhart/library?sort=rating&status=completed#profile-links doesn't validate hyperlinks by verifying that they redirect to the correct destination, it just uses some input validation (presumably RegEx). This is inferior to the aforementioned because it prevents the user using hyperlinks like https://linksta.cc/going/7365?https://twitter.com/i/user/3782186368 in order to gauge throughput.

Would remediate #2273 (comment).

ember1201 at https://kitsu.io/users/rokejulianlockhart/library?sort=rating&status=completed#profile-links only allows https://twitter.com/RokeJulianLockh, not https://twitter.com/i/user/3782186368. The latter is an account-specific permalink useful when binding the hyperlink to the username isn't desirable. Please note, however, that the Facebook entry does support this.

This is my first submitted issue! Yay!

The issue

When I dismiss announcements on the main page of the site, they don't stay dismissed, returning on page refresh.

Investigation so far

Looking at the code in site-announcements.js, clicking the cross dismiss button sends a post request to the back-end, presumably saving to a database the announcements a user has seen to filter them out.

Front-end

Fetch to get announcements

The call is made to https://kitsu.io/api/edge/feeds/site_announcements/57044?include=subject. I believe 57044 here is my user id.
The data returns 4 announcements. Each announcement seems to be split between two objects. The first has an id and a link to the second object. The second object contains the content to be shown in the announcement. This is probably linked to the "data enrichment" mentioned by the site-announcements.js.

Fetch to dismiss

Once I click on the dismiss button, the correct announcemment id seems to be sent to the back-end.

The url has a matching id. https://kitsu.io/api/edge/feeds/site_announcements/57044/_read
The response is a 200 success code.

Back-end

Bear with me here, as I have never even seen ruby code before.

The controller routes seem to be defined in routes.rb. The relevant resource seems to be jsonapi_resources :site_announcements on line 142, with the appropriate route being

post '/feeds/:group/:id/_read', to: 'feeds#mark_read'

There seems to be a site_announcements controller, but that is basically empty.

Otherwise, the controller for feeds is feeds_controller.rb, which contains the mark_read action.

  def mark_read
    activities = feed.activities.mark(:read, params[:_json])
    render_jsonapi stringify_activities(activities)
  end

mark() here appears to be the function defined in activity_list.rb:

    def mark(type, values = true)
      values = [values] if values.is_a? String
      data["mark_#{type}"] = values
      self
    end

This seems to set the field "mark_read" to true depending on the passed in json, though I'm not sure.

this bit in activity_list.rb may also be relevant:

    %i[limit offset ranking mark_read mark_seen].each do |key|
      define_method(key) do |value|
        data[key] = value
        self
      end
    end

To be honest, though I can find related pieces of code on the back-end, I am struggling to find whats wrong given that I do not know the language. Hopefully the stuff I've done above will be helpful and someone can find whats wrong.

I would like to suggest creating an official docker compose template. :)

It should be Pubblica not Pubvlica in the community feed of anime and manga

The typo is here at line 1280