hughsk / mouse-position Goto Github PK

Shouldn't these lines look like this:

    this.prev[0] = this.position[0];
    this.prev[1] = this.position[1];

just FYI

I came across this repo through https://github.com/hughsk/canvas-orbit-camera

As mentioned in the README about the flush(), I assume the use case of this function is to avoid the mouse deltaX/Y beginning stacked incorrectly during multiple raf calls without a mousemove event.

So, I did a test http://requirebin.com/?gist=8562c7545436b83f69b2
Since the mousemove call can be triggered multiple times before the raf call, it doesn't seem like a good idea in general to use the x - prevX in this module as deltaX. Because we will lose the information of the delta distance between frames. In that case, the flush() at the moment doesn't seem to be useful.

Instead, if we add a sumDeltaX/Y to this module, and use the flush to reset them into zero, that can be useful.

[Sorry for my poor English]